You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/26 18:13:18 UTC
[GitHub] [orc] omalley commented on a change in pull request #634: ORC-741: Schema Evolution missing column not handled in the presence of filters
omalley commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564726617
##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -110,10 +111,9 @@ static int findColumns(SchemaEvolution evolution,
TypeDescription fileColumn = evolution.getFileType(readerColumn);
return fileColumn == null ? -1 : fileColumn.getId();
} catch (IllegalArgumentException e) {
- if (LOG.isDebugEnabled()){
- LOG.debug("{}", e.getMessage());
- }
- return -1;
+ throw new IllegalArgumentException("Filter could not find column with name: " +
Review comment:
@pgaref what are you asking for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org