[GitHub] [zookeeper] symat commented on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style" argument parsing

[GitBox <gi...@apache.org>]

symat commented on issue #1131: ZOOKEEPER-3599: cli.c: Resuscitate "old-style" argument parsing
URL: https://github.com/apache/zookeeper/pull/1131#issuecomment-561631843
 
 
   looks great, thank you!
   
   I did some testing with your patch and I am not sure if it is caused by this PR or not, but batch mode seems not working now with `cli_mt`, only working with `cli_st`:
   
   using `cli_st` with the new and old arguments:
   ```
   root@8697285cbb47:/git/zookeeper/zookeeper-client/zookeeper-client-c/target/c/bin# ./cli_st --host localhost:2181 --cmd 'ls /'
   Batch mode: ls /
   Watcher SESSION_EVENT state = CONNECTED_STATE
   Got a new session id: 0x1000e71b8340014
   time = 4 msec
   /: rc = 0
   	zookeeper
   time = 4 msec
   
   
   root@8697285cbb47:/git/zookeeper/zookeeper-client/zookeeper-client-c/target/c/bin# ./cli_st localhost:2181 cmd:'ls /'
   Batch mode: 'ls /'
   Watcher SESSION_EVENT state = CONNECTED_STATE
   Got a new session id: 0x1000e71b8340015
   time = 6 msec
   /: rc = 0
   	zookeeper
   time = 6 msec
   
   
   root@8697285cbb47:/git/zookeeper/zookeeper-client/zookeeper-client-c/target/c/bin#
   ```
   
   But doing the same with `cli_mt` seems to be broken for me:
   ```
   root@8697285cbb47:/git/zookeeper/zookeeper-client/zookeeper-client-c/target/c/bin# ./cli_mt --host localhost:2181 --cmd 'ls /'
   Batch mode: ls /
   Watcher SESSION_EVENT state = CONNECTED_STATE
   Got a new session id: 0x1000e71b8340016
   < waits forever here.. >
   ^C
   
   root@8697285cbb47:/git/zookeeper/zookeeper-client/zookeeper-client-c/target/c/bin# ./cli_mt localhost:2181 cmd:'ls /'
   Batch mode: 'ls /'
   Watcher SESSION_EVENT state = CONNECTED_STATE
   Got a new session id: 0x1000e71b8340017
   < waits forever here.. >
   ^C
   ```
   
   I was building using `mvn clean install -Pfull-build -DskipTests` on top of an ubuntu 18.4 docker image, with the following extra packages installed: `apt update && apt install -y libcppunit-dev maven default-jdk-headless autoconf libtool g++ make software-properties-common pkg-config wget git python-setuptools openssl libssl-dev`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services