You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/26 07:17:25 UTC

[GitHub] [flink] masteryhx commented on a diff in pull request #20523: [WIP][FLINK-26372][runtime][state] Allow to configure Changelog Storage per program

masteryhx commented on code in PR #20523:
URL: https://github.com/apache/flink/pull/20523#discussion_r955729061


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChangelogStorageFactory.java:
##########
@@ -45,4 +51,16 @@ StateChangelogStorage<?> createStorage(
 
     /** Create the storage for recovery. */
     StateChangelogStorageView<?> createStorageView(Configuration configuration) throws IOException;
+
+    /** Extract the relevant to this factory portion of the configuration. */
+    default Configuration extractConfiguration(ReadableConfig src) {

Review Comment:
   IIUC, Even if users haven't setted these parameter in job level, we will still overide them in current logic?
   Should we just overide them when users have setted them ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org