You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ivandika3 (via GitHub)" <gi...@apache.org> on 2026/01/22 15:22:43 UTC
[PR] HDDS-11353. Intermittent assertion failure in TestOzoneManagerHAWithStoppedNodes#testOMHAMetrics [ozone]
ivandika3 opened a new pull request, #9660:
URL: https://github.com/apache/ozone/pull/9660
## What changes were proposed in this pull request?
The root cause should be because old leader will trigger StateMachine#notifyLeaderChanged only when it receives AppendEntries from the leader. Therefore, instead of relying on the AppendEntries from heartbeats, we can simply do some writes so that the old leader will be aware of the new leader.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11353
## How was this patch tested?
10x10: https://github.com/ivandika3/ozone/actions/runs/21250244703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11353. Intermittent failure in TestOzoneManagerHAWithStoppedNodes#testOMHAMetrics [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #9660:
URL: https://github.com/apache/ozone/pull/9660#issuecomment-3808412119
Thanks @adoroszlai @errose28 for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11353. Intermittent failure in TestOzoneManagerHAWithStoppedNodes#testOMHAMetrics [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on code in PR #9660:
URL: https://github.com/apache/ozone/pull/9660#discussion_r2719239951
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithStoppedNodes.java:
##########
@@ -513,6 +511,11 @@ void testOMHAMetrics() throws Exception {
getCluster().restartOzoneManager(leaderOM, true);
waitForLeaderToBeReady();
+ // Do some writes so that the old leader can receive AppendEntries
+ // which will trigger notifyLeaderChanged, instead of relying on
+ // AppendEntries
Review Comment:
Thanks for the review, I missed that. I'll update this if there are any other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11353. Intermittent assertion failure in TestOzoneManagerHAWithStoppedNodes#testOMHAMetrics [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #9660:
URL: https://github.com/apache/ozone/pull/9660#discussion_r2718017257
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithStoppedNodes.java:
##########
@@ -513,6 +511,11 @@ void testOMHAMetrics() throws Exception {
getCluster().restartOzoneManager(leaderOM, true);
waitForLeaderToBeReady();
+ // Do some writes so that the old leader can receive AppendEntries
+ // which will trigger notifyLeaderChanged, instead of relying on
+ // AppendEntries
Review Comment:
nit: I don't think it's worth updating just for this, but if you need to change the patch for any other reason:
```suggestion
// Do some writes so that the old leader can receive AppendEntries
// which will trigger notifyLeaderChanged, instead of relying on
// AppendEntries from heartbeats
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11353. Intermittent failure in TestOzoneManagerHAWithStoppedNodes#testOMHAMetrics [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 merged PR #9660:
URL: https://github.com/apache/ozone/pull/9660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org