[GitHub] [incubator-datasketches-postgresql] phstudy commented on issue #27: Should we treat `null` as empty sketch?

[GitBox <gi...@apache.org>]

phstudy commented on issue #27:
URL: https://github.com/apache/incubator-datasketches-postgresql/issues/27#issuecomment-659317527


   I think estimation function should return `0` rather than `null`. It's much convenient, otherwise I have to write `case with` to handle the `null` value. The estimation function in BigQuery `HLL_COUNT` also returns `0` when input value is `null`.
   
   **Estimation function**
   |Sketch| Function  | Return value |
   | ------------- | ------------- |------------- |
   | Theta Sketch  |   theta_sketch_get_estimate(null) |null|
   | [HLL_COUNT](https://cloud.google.com/bigquery/docs/reference/standard-sql/hll_functions)  |  HLL_COUNT.EXTRACT(null) |0 |


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org