You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by scottyaslan <gi...@git.apache.org> on 2016/09/30 01:16:25 UTC
[GitHub] nifi pull request #1082: [NIFI-2496] Zoom Fit now accounts for an open palet...
GitHub user scottyaslan opened a pull request:
https://github.com/apache/nifi/pull/1082
[NIFI-2496] Zoom Fit now accounts for an open palette as well as the \u2026
\u2026breadcrumb bar
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scottyaslan/nifi NIFI-2496
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1082.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1082
----
commit 58decaae9d9cdc6bda3d1a69336874fd4dd0bf5a
Author: Scott Aslan <sc...@gmail.com>
Date: 2016-09-30T01:15:04Z
[NIFI-2496] Zoom Fit now accounts for an open palette as well as the breadcrumb bar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1082: [NIFI-2496] Zoom Fit now accounts for an open palette as w...
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1082
@scottyaslan @mcgilman is this still relevant/open?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1082: [NIFI-2496] Zoom Fit now accounts for an open palette as w...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/1082
@mcgilman @joewitt it appears as though this approach does something to adjust the zoom behavior but is not solving the root of the problem. I am closing this PR and cancelling the patch. We will need to revisit the issue...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1082: [NIFI-2496] Zoom Fit now accounts for an open palette as w...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1082
The proposed changes seem to help introduce some space from the upper left hand corner of the canvas but don't seem to account for the entire width of the graph controls. Could it possible be an issue with the scale?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1082: [NIFI-2496] Zoom Fit now accounts for an open palette as w...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1082
Reviewing..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1082: [NIFI-2496] Zoom Fit now accounts for an open palet...
Posted by scottyaslan <gi...@git.apache.org>.
Github user scottyaslan closed the pull request at:
https://github.com/apache/nifi/pull/1082
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---