[jira] [Commented] (HBASE-28972) Limit the number of retries in FanOutOneBlockAsyncDFSOutputHelper.completeFile

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-28972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897390#comment-17897390 ] 

Hudson commented on HBASE-28972:
--------------------------------

Results for branch branch-2.6
	[build #238 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/238/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/238/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/238/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/238/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/238/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/238/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop ${HADOOP_THREE_VERSION} backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/238/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk17 hadoop ${HADOOP_THREE_VERSION} backward compatibility checks{color}
-- For more information [see jdk17 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/238/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test for HBase 2 {color}
(/) {color:green}+1 client integration test for 3.3.5 {color}
(/) {color:green}+1 client integration test for 3.3.6 {color}
(/) {color:green}+1 client integration test for 3.4.0 {color}


> Limit the number of retries in FanOutOneBlockAsyncDFSOutputHelper.completeFile
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-28972
>                 URL: https://issues.apache.org/jira/browse/HBASE-28972
>             Project: HBase
>          Issue Type: Improvement
>          Components: Filesystem Integration, io, wal
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.7.0, 3.0.0-beta-2, 2.5.11, 2.6.2
>
>
> After HBASE-28955, when shutting down MiniDFSCluster, we will close all the output streams. 
> And in some WAL related tests, we want to keep the WAL file as open so we set namenode to safe mode before shutting down, like TestWALFactory.testAppendClose.
> And in FanOutOneBlockAsyncDFSOutputHelper.completeFile, we will only give up when hitting LeaseExpireException, so in this scenario, we will block there forever...
> In general, if there is an error while complete file, we could go with the recoverLease logic so it is OK to throw exception when completeFile. We should change the implementation so it does not block there forever.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)