[GitHub] [daffodil] mike-mcgann commented on pull request #947: Add scalafmt

["mike-mcgann (via GitHub)" <gi...@apache.org>]

mike-mcgann commented on PR #947:
URL: https://github.com/apache/daffodil/pull/947#issuecomment-1420823188

   > This needs to be rebased to fix the conflicts now that OSGI is merged.
   
   Updated
   
   > Also, we need to figure out how to handle the windows failures. Git on windows enables autocrlf so all the files end in CRLF instead of LF and scalafmt complains. We could just add a condition so the check only runs on linux. Or maybe a better options is to split it off into another job?
   
   I changed it to only run on linux. I think another job for checks seems a little heavy. It will probably take longer to install and prepare the environment than to run the tests. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org