You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "aner-perez (via GitHub)" <gi...@apache.org> on 2025/11/11 18:39:29 UTC
[PR] Fix issue where activation-group is not applied after rule fires initially. fixes #6509 [incubator-kie-drools]
aner-perez opened a new pull request, #6517:
URL: https://github.com/apache/incubator-kie-drools/pull/6517
If multiple rules in the same activation-group are re-triggered by a fact change, any subsequent firing of these rules do not cancel other activations for the activation-group.
A unit test is included that reproduces the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix issue where activation-group is not applied after rule fires initially. fixes #6509 [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas commented on PR #6517:
URL: https://github.com/apache/incubator-kie-drools/pull/6517#issuecomment-3521145923
Thank you @aner-perez , the fix looks pretty valid.
Just one point, recently we have introduced `TrackingAgendaEventListener` which is exactly useful for test cases like yours.
https://github.com/apache/incubator-kie-drools/blob/main/drools-core/src/main/java/org/drools/core/event/TrackingAgendaEventListener.java
So your custom eventListener can be replaced like this:
https://github.com/apache/incubator-kie-drools/blob/main/drools-model/drools-model-codegen/src/test/java/org/drools/model/codegen/execmodel/ActivationGroupDualFactMatchTest.java#L140-L141
https://github.com/apache/incubator-kie-drools/blob/main/drools-model/drools-model-codegen/src/test/java/org/drools/model/codegen/execmodel/ActivationGroupDualFactMatchTest.java#L175-L177
Please use TrackingAgendaEventListener. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix issue where activation-group is not applied after rule fires initially. fixes #6509 [incubator-kie-drools]
Posted by "tkobayas (via GitHub)" <gi...@apache.org>.
tkobayas merged PR #6517:
URL: https://github.com/apache/incubator-kie-drools/pull/6517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Fix issue where activation-group is not applied after rule fires initially. fixes #6509 [incubator-kie-drools]
Posted by "aner-perez (via GitHub)" <gi...@apache.org>.
aner-perez commented on PR #6517:
URL: https://github.com/apache/incubator-kie-drools/pull/6517#issuecomment-3525115473
Thanks for reviewing this @tkobayas , I changed the unit test to use TrackingAgendaEventListener as suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org