You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by GitBox <gi...@apache.org> on 2020/01/15 18:53:33 UTC
[GitHub] [incubator-toree] gmcoringa commented on issue #180: [TOREE-508]
Reply errors to iopub.error instead of iopub.exec_result
gmcoringa commented on issue #180: [TOREE-508] Reply errors to iopub.error instead of iopub.exec_result
URL: https://github.com/apache/incubator-toree/pull/180#issuecomment-574800328
> I believe we are going in the right direction here, but with the change on behavior the errors are not completely showing up on the notebook interface.
>
> Original behavior:
> 
>
> And with the changes from this pr:
> 
>
> As shown in the picture above, the contents are not all there, and the cell is not scrollable anymore.
The error is not completely showing because of the code below found in [ScalaInterpreterSpecific.scala#L429](https://github.com/apache/incubator-toree/blob/master/scala-interpreter/src/main/scala-2.11/org/apache/toree/kernel/interpreter/scala/ScalaInterpreterSpecific.scala#L429):
```java
ExecuteError(
ex.getClass.getName,
ex.getLocalizedMessage,
formattedException.slice(1, formattedException.size - 1).toList
)
```
Which removes the first line from the stack, I don't know why, but I believe that this should not be done.
About the scrollable, testing with python kernels seems to have the same behaviour (errors are not scrollable).
So @lresende if you think its better I can fix the removal of messages from the stack trace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services