You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by cwestin <gi...@git.apache.org> on 2015/09/11 22:16:24 UTC

[GitHub] drill pull request: DRILL-1942-readers:

GitHub user cwestin opened a pull request:

    https://github.com/apache/drill/pull/154

    DRILL-1942-readers:

    - add extends AutoCloseable to RecordReader, and rename cleanup() to close() on derived classes.
    - fix many warnings
    - formatting fixes
    
    unit tests pass
    presubmit regression and customer passes
    presubmit tpc-h SF100 passes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cwestin/incubator-drill alloc-readers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
    
----
commit 2b23db2dcc1a6548b6f791379678b9df6ceece27
Author: Chris Westin <cw...@yahoo.com>
Date:   2015-09-11T01:28:00Z

    DRILL-1942-readers:
    - add extends AutoCloseable to RecordReader, and rename cleanup() to close().
    - fix many warnings
    - formatting fixes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-1942-readers:

Posted by amansinha100 <gi...@git.apache.org>.
Github user amansinha100 commented on the pull request:

    https://github.com/apache/drill/pull/154#issuecomment-139897179
  
    +1  LGTM. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-1942-readers:

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/154


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---