You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/20 08:02:18 UTC

[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #12946: [Improvement-12945][Tools] improvement: fix some sonarlint warning and file name spell error

Radeity commented on code in PR #12946:
URL: https://github.com/apache/dolphinscheduler/pull/12946#discussion_r1027243328


##########
dolphinscheduler-tools/src/main/java/org/apache/dolphinscheduler/tools/demo/ProxyProcessDefinitionController.java:
##########
@@ -71,7 +70,7 @@ public ProxyResult createProcessDefinition(String token,
         } catch (IOException e) {
             throw new RuntimeException(e);
         }
-        proxyResult = JSONUtils.parseObject(responseBody, ProxyResult.class);
+        ProxyResult proxyResult = JSONUtils.parseObject(responseBody, ProxyResult.class);

Review Comment:
   ```suggestion
           return JSONUtils.parseObject(responseBody, ProxyResult.class);
   ```



##########
dolphinscheduler-tools/src/main/java/org/apache/dolphinscheduler/tools/demo/ProxyProcessDefinitionController.java:
##########
@@ -71,7 +70,7 @@ public ProxyResult createProcessDefinition(String token,
         } catch (IOException e) {
             throw new RuntimeException(e);
         }
-        proxyResult = JSONUtils.parseObject(responseBody, ProxyResult.class);
+        ProxyResult proxyResult = JSONUtils.parseObject(responseBody, ProxyResult.class);
 
         return proxyResult;

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org