You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/01/14 21:45:38 UTC
[incubator-iceberg] Diff for: [GitHub] rdblue merged pull request #66:
Update struct fields for doc-only changes.
diff --git a/core/src/main/java/com/netflix/iceberg/SchemaUpdate.java b/core/src/main/java/com/netflix/iceberg/SchemaUpdate.java
index 65e78393..4e7f290a 100644
--- a/core/src/main/java/com/netflix/iceberg/SchemaUpdate.java
+++ b/core/src/main/java/com/netflix/iceberg/SchemaUpdate.java
@@ -30,6 +30,7 @@
import java.util.Collection;
import java.util.List;
import java.util.Map;
+import java.util.Objects;
import static com.netflix.iceberg.types.Types.NestedField.optional;
import static com.netflix.iceberg.types.Types.NestedField.required;
@@ -261,7 +262,9 @@ public Type struct(Types.StructType struct, List<Type> fieldResults) {
doc = update.doc();
}
- if (!name.equals(field.name()) || field.type() != resultType) {
+ if (!name.equals(field.name()) ||
+ field.type() != resultType ||
+ !Objects.equals(doc, field.doc())) {
hasChange = true;
if (field.isOptional()) {
newFields.add(optional(field.fieldId(), name, resultType, doc));
With regards,
Apache Git Services