You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/14 16:49:51 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 edited a comment on pull request #382: Remove -x from cibuild.sh call in CI since this will abort the build on first error and we do not want that

xiaoxiang781216 edited a comment on pull request #382:
URL: https://github.com/apache/incubator-nuttx-apps/pull/382#issuecomment-692179992


   > > Sure, I will open a thread.
   > 
   > @xiaoxiang781216 I'm inclined to not because if we do create some GitHub Actions via nodejs they will add quite a bit of code that does not really need to be in the OS. We will also pay a fairly large cost cloning the repo because of the OS repo size.
   > 
   
   The automation build script is composed by two part:
   
   1. The core script(cibuild.sh, *.dat and Dockfile)
   2. The github specific script(under .github/)
   
   The first category is very small and reusable in any environment. My suggestion is moving this category to nuttx/tools.
   
   > This also still does not solve having to keep the workflows in sync with apps.
   > 
   > The fact that it is on the public roadmap to share workflows across repos makes me hopeful
   
   The second category which tightly couple with the github workflow and duplicate in three repos, still keep as the current state until you have to time to optimize them to the perfect shape.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org