[GitHub] [pulsar] sijie commented on a change in pull request #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #3848: [Issue-2122] [pulsar-client] Adding configuration for backoff strategy
URL: https://github.com/apache/pulsar/pull/3848#discussion_r266557282
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/Backoff.java
 ##########
 @@ -40,19 +42,33 @@
 
     @VisibleForTesting
     Backoff(long initial, TimeUnit unitInitial, long max, TimeUnit unitMax, long mandatoryStop,
-            TimeUnit unitMandatoryStop, Clock clock) {
+            TimeUnit unitMandatoryStop, Clock clock, long backoffIntervalNanos, long maxBackoffIntervalNanos) {
 
 Review comment:
   since we are introducing new fields in the constructor and getting more and more constructors, it might be a good time to rewrite this class to use Builder pattern.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services