You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/07/24 09:52:34 UTC
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert opened a new pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
bosschaert opened a new pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2
An additional bundle with the classifier -nodeps is now generated which
does not contain the javax.activation classes/activation.jar file.
Also updated parent pom to latest version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] rombert commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663502172
> Good point. I agree that that's better. I have pushed a change for this.
Looks good, thanks!
> It would be nice yes, but not essential IMHO. I think that would be better done as part of a different JIRA issue.
Agreed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460150688
##########
File path: pom.xml
##########
@@ -77,6 +100,7 @@
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
+ <version>4.2.0</version>
Review comment:
This is managed in parent v34. Do we really want to support OSGi R4.2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460173844
##########
File path: pom.xml
##########
@@ -50,14 +50,37 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
+ <version>5.1.1</version>
Review comment:
Ok - I downgraded to 34, so I guess this part can be marked as resolved?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460150864
##########
File path: pom.xml
##########
@@ -77,6 +100,7 @@
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
+ <version>4.2.0</version>
Review comment:
This is managed in parent v34. Do we really want to support OSGi R4.2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663482643
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved
=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] removed a comment on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663461739
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved
=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460086462
##########
File path: pom.xml
##########
@@ -50,14 +50,37 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
+ <version>5.1.1</version>
Review comment:
Migrating to bnd is required with newest parent: https://github.com/apache/sling-parent/blob/133c73392e9575cb10ced19ce29e14e7ec61c790/sling-bundle-parent/pom.xml#L168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663509526
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved
=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460173604
##########
File path: pom.xml
##########
@@ -77,6 +100,7 @@
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
+ <version>4.2.0</version>
Review comment:
OSGi R 4.2 is the minimum OSGi API version that this code needs. It does not require anything newer than that right now so why increase the APIs that it uses higher than what it actually needs? It will work on any OSGi version after that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460130992
##########
File path: pom.xml
##########
@@ -23,7 +23,7 @@
<parent>
<groupId>org.apache.sling</groupId>
<artifactId>sling</artifactId>
- <version>26</version>
+ <version>39</version>
Review comment:
Then please stick with a version <= 34. Referencing the newest generic (non-bundle) parent feels just wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460093321
##########
File path: pom.xml
##########
@@ -23,7 +23,7 @@
<parent>
<groupId>org.apache.sling</groupId>
<artifactId>sling</artifactId>
- <version>26</version>
+ <version>39</version>
Review comment:
Using the sling-bundle-parent would require moving to the bnd-maven-plugin, which I agree can be done, but I would say is not required here. It can be done as part of a different JIRA issue as discussed with @rombert above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460149194
##########
File path: pom.xml
##########
@@ -50,14 +50,37 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
+ <version>5.1.1</version>
Review comment:
I don’t require update to bnd-m-p. But please don’t upgrade to parent above 34 as that does no longer properly support m-bundle-plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] rombert commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663469615
Shouldn't the bundles have different symbolic names but same version? I know it does not make sense to install them both side by side, but on the other hand debugging would be easier as usually the BSN is printed all of the time, but the version isn't.
It would also be nice to switch to the `bnd-maven-plugin` as part of the change, if you already moved to the latest parent pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460131163
##########
File path: pom.xml
##########
@@ -77,6 +100,7 @@
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
+ <version>4.2.0</version>
Review comment:
See above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] removed a comment on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663509526
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved
=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] rombert commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663502889
BTW, I get the following warning when building ( sorry, did not spot it earlier )
```
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.apache.sling:org.apache.sling.javax.activation:bundle:0.1.1-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.apache.felix:maven-bundle-plugin is missing. @ line 50, column 21
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
```
I think this happens because we no longer configure the `maven-bundle-plugin` in the parent pom. Can you please set a version for the plug-in? It would also be good to double-check that all settings are applied correctly, as the OSGi specific parts have been moved to `org.apache.sling:sling-bundle-parent`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
bosschaert commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663509118
Thanks @rombert, well spotted! I've added a version for the `maven-bundle-plugin` now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] removed a comment on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663482643
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved
=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663461739
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved
=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] sonarcloud[bot] commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663613634
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved
=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-javax-activation&pullRequest=2&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin merged pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin merged pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460149194
##########
File path: pom.xml
##########
@@ -50,14 +50,37 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
+ <version>5.1.1</version>
Review comment:
I don’t require update to bnd-m-p. But in the case you don’t use bnd-m-p please don’t upgrade to parent above 34 as that does no longer properly support m-bundle-plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460150688
##########
File path: pom.xml
##########
@@ -77,6 +100,7 @@
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
+ <version>4.2.0</version>
Review comment:
This is managed in parent v34. Do we really want to support OSGi R4.2? (https://github.com/apache/sling-parent/blob/821e20cd664144d973f63f5f4201ab71322fa800/pom.xml#L1167)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460093623
##########
File path: pom.xml
##########
@@ -77,6 +100,7 @@
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
+ <version>4.2.0</version>
Review comment:
sling parent 39 does not have a managed version of org.osgi.core
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
bosschaert commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460095344
##########
File path: pom.xml
##########
@@ -50,14 +50,37 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
+ <version>5.1.1</version>
Review comment:
There are 2 parent poms: sling 39 and sling-bundle-parent 39. This project has used sling and I just updated that to the latest of that one. sling 39 does not require migrating to bnd, it's the other one that does.
If you veto this PR because you think it must be migrated to sling-bundle-parent please let me know, otherwise I suggest that we merge this PR and the migration to the bnd-maven-plugin and sling-bundle-parent can be done separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] bosschaert commented on pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
bosschaert commented on pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#issuecomment-663482455
Hi @rombert
> Shouldn't the bundles have different symbolic names but same version.
Good point. I agree that that's better. I have pushed a change for this.
> It would also be nice to switch to the bnd-maven-plugin as part of the change, if you already moved to the latest parent pom.
It would be nice yes, but not essential IMHO. I think that would be better done as part of a different JIRA issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-javax-activation] kwin commented on a change in pull request #2: SLING-9601 Provide a Sling javax.activation bundle without dependencies built in
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-javax-activation/pull/2#discussion_r460084565
##########
File path: pom.xml
##########
@@ -23,7 +23,7 @@
<parent>
<groupId>org.apache.sling</groupId>
<artifactId>sling</artifactId>
- <version>26</version>
+ <version>39</version>
Review comment:
Please use 'sling-bundle-parent' as artifact id (https://github.com/apache/sling-parent/blob/133c73392e9575cb10ced19ce29e14e7ec61c790/sling-bundle-parent/pom.xml#L29)
##########
File path: pom.xml
##########
@@ -77,6 +100,7 @@
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.core</artifactId>
+ <version>4.2.0</version>
Review comment:
Please use the managed artifacts from the bundle-parent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org