You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by "shreemaan-abhishek (via GitHub)" <gi...@apache.org> on 2026/04/01 08:24:23 UTC

Re: [PR] fix(admin): skip etcd call in global_rules validation for standalone mode [apisix]

shreemaan-abhishek commented on code in PR #13122:
URL: https://github.com/apache/apisix/pull/13122#discussion_r3020569714


##########
apisix/admin/global_rules.lua:
##########
@@ -24,6 +24,11 @@ local ipairs   = ipairs
 local tostring = tostring
 
 local function get_global_rules()
+    local local_conf = core.config.local_conf()
+    if local_conf.deployment.config_provider == "yaml" then

Review Comment:
   `get_global_rules` is used to check if the incoming global rule conflicts with existing global rules, skipping the check entirely doesn't seem correct.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org