You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Henry Saginor (JIRA)" <ji...@apache.org> on 2012/11/21 02:36:58 UTC

[jira] [Created] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Henry Saginor created FELIX-3769:
------------------------------------

             Summary: Improve the way Web Console UI manages growing number of plugins.
                 Key: FELIX-3769
                 URL: https://issues.apache.org/jira/browse/FELIX-3769
             Project: Felix
          Issue Type: New Feature
          Components: Web Console
            Reporter: Henry Saginor
            Priority: Minor


Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    

Felix Meschberger has proposed the following on the dev list to implement this.

"* Plugins registered as services may have a "felix.webconsole.category" property
indicating the category. Plugins not registering this property will be placed in
the default category
* AbstractWebConsolePlugin is ammended with a getCategory() method, which may
overwritten by implementations. The default implementation in the
AbstractWebConsolePlugin class returns the default category
* A default category can be configured
* Categories are simple strings such as "OSGi" or relative paths such as
"Sling/Main". Relative paths define multi-level trees. I think in general a
single level is probably enough. Maybe we can start with just supporting a
single level (so just plain strings).
* Translation of categories is such that each segment in the path (or the
complete string if there is no sub-categories) is converted into a translation
label by prefixing with "category.". So the translation for the "OSGi" category
would be found with the translation string "category.OSGi".
* The plugin navigation is refactored to move it to the left and render it as a
tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504613#comment-13504613 ] 

Felix Meschberger commented on FELIX-3769:
------------------------------------------

Thanks for the archive. We generally prefer real patches (not modified classes in full packaged in a ZIP) because this helps analyzing the differences.

You can create a patch easily using the svn diff command or using the "create patch" functionality in your IDE.
                
> Improve the way Web Console UI manages growing number of plugins.
> -----------------------------------------------------------------
>
>                 Key: FELIX-3769
>                 URL: https://issues.apache.org/jira/browse/FELIX-3769
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Priority: Minor
>         Attachments: FELIX-3769.tar.gz
>
>
> Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    
> Felix Meschberger has proposed the following on the dev list to implement this.
> "* Plugins registered as services may have a "felix.webconsole.category" property
> indicating the category. Plugins not registering this property will be placed in
> the default category
> * AbstractWebConsolePlugin is ammended with a getCategory() method, which may
> overwritten by implementations. The default implementation in the
> AbstractWebConsolePlugin class returns the default category
> * A default category can be configured
> * Categories are simple strings such as "OSGi" or relative paths such as
> "Sling/Main". Relative paths define multi-level trees. I think in general a
> single level is probably enough. Maybe we can start with just supporting a
> single level (so just plain strings).
> * Translation of categories is such that each segment in the path (or the
> complete string if there is no sub-categories) is converted into a translation
> label by prefixing with "category.". So the translation for the "OSGi" category
> would be found with the translation string "category.OSGi".
> * The plugin navigation is refactored to move it to the left and render it as a
> tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Posted by "Henry Saginor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saginor updated FELIX-3769:
---------------------------------

    Attachment: FELIX-3769.tar.gz

I am sorry for not following the correct process. Updated attachment contains patch files.
                
> Improve the way Web Console UI manages growing number of plugins.
> -----------------------------------------------------------------
>
>                 Key: FELIX-3769
>                 URL: https://issues.apache.org/jira/browse/FELIX-3769
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Priority: Minor
>         Attachments: FELIX-3769.tar.gz, FELIX-3769.tar.gz
>
>
> Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    
> Felix Meschberger has proposed the following on the dev list to implement this.
> "* Plugins registered as services may have a "felix.webconsole.category" property
> indicating the category. Plugins not registering this property will be placed in
> the default category
> * AbstractWebConsolePlugin is ammended with a getCategory() method, which may
> overwritten by implementations. The default implementation in the
> AbstractWebConsolePlugin class returns the default category
> * A default category can be configured
> * Categories are simple strings such as "OSGi" or relative paths such as
> "Sling/Main". Relative paths define multi-level trees. I think in general a
> single level is probably enough. Maybe we can start with just supporting a
> single level (so just plain strings).
> * Translation of categories is such that each segment in the path (or the
> complete string if there is no sub-categories) is converted into a translation
> label by prefixing with "category.". So the translation for the "OSGi" category
> would be found with the translation string "category.OSGi".
> * The plugin navigation is refactored to move it to the left and render it as a
> tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Posted by "Henry Saginor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503638#comment-13503638 ] 

Henry Saginor edited comment on FELIX-3769 at 11/26/12 7:17 AM:
----------------------------------------------------------------

Attachment includes:
src/main/java/org/apache/felix/webconsole/WebConsoleConstans.java
src/main/java/org/apache/felix/webconsole/AbstractWebConsolePlugin.java
src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java
                
      was (Author: hsaginor@gmail.com):
    Attachment includes:
src/main/java/org/apache/felix/webconsole/WebConsoleConstansrc/main/java/org/apache/felix/webconsole/AbstractWebConsolePlugin.java
src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java
                  
> Improve the way Web Console UI manages growing number of plugins.
> -----------------------------------------------------------------
>
>                 Key: FELIX-3769
>                 URL: https://issues.apache.org/jira/browse/FELIX-3769
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Priority: Minor
>         Attachments: FELIX-3769.tar.gz
>
>
> Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    
> Felix Meschberger has proposed the following on the dev list to implement this.
> "* Plugins registered as services may have a "felix.webconsole.category" property
> indicating the category. Plugins not registering this property will be placed in
> the default category
> * AbstractWebConsolePlugin is ammended with a getCategory() method, which may
> overwritten by implementations. The default implementation in the
> AbstractWebConsolePlugin class returns the default category
> * A default category can be configured
> * Categories are simple strings such as "OSGi" or relative paths such as
> "Sling/Main". Relative paths define multi-level trees. I think in general a
> single level is probably enough. Maybe we can start with just supporting a
> single level (so just plain strings).
> * Translation of categories is such that each segment in the path (or the
> complete string if there is no sub-categories) is converted into a translation
> label by prefixing with "category.". So the translation for the "OSGi" category
> would be found with the translation string "category.OSGi".
> * The plugin navigation is refactored to move it to the left and render it as a
> tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501739#comment-13501739 ] 

Felix Meschberger commented on FELIX-3769:
------------------------------------------

Thanks for reporting.

Here is the link to the discussion: http://markmail.org/message/wrjfpggntjsxqpsw
                
> Improve the way Web Console UI manages growing number of plugins.
> -----------------------------------------------------------------
>
>                 Key: FELIX-3769
>                 URL: https://issues.apache.org/jira/browse/FELIX-3769
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Priority: Minor
>
> Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    
> Felix Meschberger has proposed the following on the dev list to implement this.
> "* Plugins registered as services may have a "felix.webconsole.category" property
> indicating the category. Plugins not registering this property will be placed in
> the default category
> * AbstractWebConsolePlugin is ammended with a getCategory() method, which may
> overwritten by implementations. The default implementation in the
> AbstractWebConsolePlugin class returns the default category
> * A default category can be configured
> * Categories are simple strings such as "OSGi" or relative paths such as
> "Sling/Main". Relative paths define multi-level trees. I think in general a
> single level is probably enough. Maybe we can start with just supporting a
> single level (so just plain strings).
> * Translation of categories is such that each segment in the path (or the
> complete string if there is no sub-categories) is converted into a translation
> label by prefixing with "category.". So the translation for the "OSGi" category
> would be found with the translation string "category.OSGi".
> * The plugin navigation is refactored to move it to the left and render it as a
> tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Posted by "Henry Saginor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Saginor updated FELIX-3769:
---------------------------------

    Attachment: FELIX-3769.tar.gz

Attachment includes:
src/main/java/org/apache/felix/webconsole/WebConsoleConstansrc/main/java/org/apache/felix/webconsole/AbstractWebConsolePlugin.java
src/main/java/org/apache/felix/webconsole/internal/servlet/PluginHolder.java
                
> Improve the way Web Console UI manages growing number of plugins.
> -----------------------------------------------------------------
>
>                 Key: FELIX-3769
>                 URL: https://issues.apache.org/jira/browse/FELIX-3769
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Priority: Minor
>         Attachments: FELIX-3769.tar.gz
>
>
> Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    
> Felix Meschberger has proposed the following on the dev list to implement this.
> "* Plugins registered as services may have a "felix.webconsole.category" property
> indicating the category. Plugins not registering this property will be placed in
> the default category
> * AbstractWebConsolePlugin is ammended with a getCategory() method, which may
> overwritten by implementations. The default implementation in the
> AbstractWebConsolePlugin class returns the default category
> * A default category can be configured
> * Categories are simple strings such as "OSGi" or relative paths such as
> "Sling/Main". Relative paths define multi-level trees. I think in general a
> single level is probably enough. Maybe we can start with just supporting a
> single level (so just plain strings).
> * Translation of categories is such that each segment in the path (or the
> complete string if there is no sub-categories) is converted into a translation
> label by prefixing with "category.". So the translation for the "OSGi" category
> would be found with the translation string "category.OSGi".
> * The plugin navigation is refactored to move it to the left and render it as a
> tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508324#comment-13508324 ] 

Felix Meschberger commented on FELIX-3769:
------------------------------------------

Thanks for the updated patch. I have applied it slightly modified and extended in Rev. 1416231

  * Some adaptions to the CSS and integrated with main CSS
  * Moved the menu setup to the main_header.html template
  * Created default category "Main"
  * All plugins added to the "Main" category if no defined otherwise
  * Web Console plugins categorized

This now basically works, but there are open issues:

  * The default category is "Main": should that be configurable or a different name ?
  * Categories are not translated yet: do we want that ? Using the WebConsole bundle ?
  * The menu entries are sorted by label instead of by Title
  * The localized label map is not a flat map but a tree of categories and menu entries

The last issue basically constitutes a backwards incompatibility.
                
> Improve the way Web Console UI manages growing number of plugins.
> -----------------------------------------------------------------
>
>                 Key: FELIX-3769
>                 URL: https://issues.apache.org/jira/browse/FELIX-3769
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Priority: Minor
>         Attachments: FELIX-3769.tar.gz, FELIX-3769.tar.gz
>
>
> Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    
> Felix Meschberger has proposed the following on the dev list to implement this.
> "* Plugins registered as services may have a "felix.webconsole.category" property
> indicating the category. Plugins not registering this property will be placed in
> the default category
> * AbstractWebConsolePlugin is ammended with a getCategory() method, which may
> overwritten by implementations. The default implementation in the
> AbstractWebConsolePlugin class returns the default category
> * A default category can be configured
> * Categories are simple strings such as "OSGi" or relative paths such as
> "Sling/Main". Relative paths define multi-level trees. I think in general a
> single level is probably enough. Maybe we can start with just supporting a
> single level (so just plain strings).
> * Translation of categories is such that each segment in the path (or the
> complete string if there is no sub-categories) is converted into a translation
> label by prefixing with "category.". So the translation for the "OSGi" category
> would be found with the translation string "category.OSGi".
> * The plugin navigation is refactored to move it to the left and render it as a
> tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Posted by "Henry Saginor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503646#comment-13503646 ] 

Henry Saginor commented on FELIX-3769:
--------------------------------------

Attached archive contains a patch with a possible implementation.
The main_header.html included with FELIX-3770 also includes some CSS styles. This patch also depends on FELIX-3770 for JQuery UI.

This implements the following specification.
1) A plugin extending AbstractWebConsolePugin can specify a category by either setting felix.webconsole.category property or overriding getCategory() method.
2) The felix.webconsole.category property takes precedence.
3) The default implementation of getCategory() just returns null. If it's null the plugin link is displayed as the top level menu item. So, this is the default.
4) Multiple levels for categories can be specified as a path. For example "OSGi/Configuration".
5) If there is a collision between a category and a plugin title at the same level 2 menu items will be rendered.  
                
> Improve the way Web Console UI manages growing number of plugins.
> -----------------------------------------------------------------
>
>                 Key: FELIX-3769
>                 URL: https://issues.apache.org/jira/browse/FELIX-3769
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>            Reporter: Henry Saginor
>            Priority: Minor
>         Attachments: FELIX-3769.tar.gz
>
>
> Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    
> Felix Meschberger has proposed the following on the dev list to implement this.
> "* Plugins registered as services may have a "felix.webconsole.category" property
> indicating the category. Plugins not registering this property will be placed in
> the default category
> * AbstractWebConsolePlugin is ammended with a getCategory() method, which may
> overwritten by implementations. The default implementation in the
> AbstractWebConsolePlugin class returns the default category
> * A default category can be configured
> * Categories are simple strings such as "OSGi" or relative paths such as
> "Sling/Main". Relative paths define multi-level trees. I think in general a
> single level is probably enough. Maybe we can start with just supporting a
> single level (so just plain strings).
> * Translation of categories is such that each segment in the path (or the
> complete string if there is no sub-categories) is converted into a translation
> label by prefixing with "category.". So the translation for the "OSGi" category
> would be found with the translation string "category.OSGi".
> * The plugin navigation is refactored to move it to the left and render it as a
> tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (FELIX-3769) Improve the way Web Console UI manages growing number of plugins.

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated FELIX-3769:
-------------------------------------

    Affects Version/s: webconsole-4.0.0
        Fix Version/s: webconsole-4.0.2
             Assignee: Felix Meschberger
    
> Improve the way Web Console UI manages growing number of plugins.
> -----------------------------------------------------------------
>
>                 Key: FELIX-3769
>                 URL: https://issues.apache.org/jira/browse/FELIX-3769
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>    Affects Versions: webconsole-4.0.0
>            Reporter: Henry Saginor
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: webconsole-4.0.2
>
>         Attachments: FELIX-3769.tar.gz, FELIX-3769.tar.gz
>
>
> Something needs to be done about growing number of web console plugins. Currently the UI displays a tab for each plugin. This makes the UI cluttered as more and more plugins are added. To address the tabs should be replaced with a tree structure or a drop-down menu.    
> Felix Meschberger has proposed the following on the dev list to implement this.
> "* Plugins registered as services may have a "felix.webconsole.category" property
> indicating the category. Plugins not registering this property will be placed in
> the default category
> * AbstractWebConsolePlugin is ammended with a getCategory() method, which may
> overwritten by implementations. The default implementation in the
> AbstractWebConsolePlugin class returns the default category
> * A default category can be configured
> * Categories are simple strings such as "OSGi" or relative paths such as
> "Sling/Main". Relative paths define multi-level trees. I think in general a
> single level is probably enough. Maybe we can start with just supporting a
> single level (so just plain strings).
> * Translation of categories is such that each segment in the path (or the
> complete string if there is no sub-categories) is converted into a translation
> label by prefixing with "category.". So the translation for the "OSGi" category
> would be found with the translation string "category.OSGi".
> * The plugin navigation is refactored to move it to the left and render it as a
> tree structure (I assume we can use the JQuery treetable plugin)."

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira