[GitHub] [druid] clintropolis commented on pull request #10429: vectorize remaining math expressions

[GitBox <gi...@apache.org>]

clintropolis commented on pull request #10429:
URL: https://github.com/apache/druid/pull/10429#issuecomment-698723996


   The tests were failing due a bug/feature gap uncovered with vectorized group by engine when grouping on numeric columns with null values (nulls are ignored and so results are incorrect).
   
   For this PR, I have temporarily added a check for `columnCapabilities.hasNulls().isFalse()` to disable vectorization if this is true (which it is for all expression virtual columns, so i had to add back a handful of `cannotVectorize()` calls to tests if sql compatible null handling is enabled). In a follow-up PR I will fix this feature gap for real to allow this to function again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org