You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/03 17:23:05 UTC
[GitHub] [tvm] comaniac commented on a change in pull request #7020: [AutoScheduler] Misc update to hardware parameter and task scheduler
comaniac commented on a change in pull request #7020:
URL: https://github.com/apache/tvm/pull/7020#discussion_r535429580
##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -168,15 +175,17 @@ def conv2d_strategy_cpu(attrs, inputs, out_type, target):
else: # group_conv2d
if layout == "NCHW":
assert kernel_layout == "OIHW"
- logger.warning("group_conv2d is not optimized for x86.")
+ if not is_auto_scheduler_enabled():
+ logger.warning("group_conv2d is not optimized for x86.")
Review comment:
`with autotvm`?
##########
File path: python/tvm/relay/op/strategy/x86.py
##########
@@ -168,15 +175,17 @@ def conv2d_strategy_cpu(attrs, inputs, out_type, target):
else: # group_conv2d
if layout == "NCHW":
assert kernel_layout == "OIHW"
- logger.warning("group_conv2d is not optimized for x86.")
+ if not is_auto_scheduler_enabled():
+ logger.warning("group_conv2d is not optimized for x86.")
strategy.add_implementation(
wrap_compute_conv2d(topi.nn.group_conv2d_nchw, has_groups=True),
wrap_topi_schedule(topi.generic.schedule_group_conv2d_nchw),
name="group_conv2d_nchw.generic",
)
elif layout == "NHWC":
assert kernel_layout == "HWIO"
- logger.warning("group_conv2d is not optimized for x86.")
+ if not is_auto_scheduler_enabled():
+ logger.warning("group_conv2d is not optimized for x86.")
Review comment:
`with autotvm`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org