You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2015/10/26 18:52:28 UTC
[GitHub] flink pull request: Add org.apache.httpcomponents:(httpcore, httpc...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1301
Add org.apache.httpcomponents:(httpcore, httpclient) to dependency management
Hadoop 2.4.0 has `httpcomponents` dependencies, which breaks Flink on Amazon EMR AMI 3.9, because 4.1.2 is missing a method, on which `EmrFileSystem` relies.
```bash
[INFO] org.apache.flink:flink-shaded-hadoop2:jar:1.0-SNAPSHOT
...
[INFO] | +- net.java.dev.jets3t:jets3t:jar:0.9.0:compile
[INFO] | | +- org.apache.httpcomponents:httpclient:jar:4.1.2:compile
[INFO] | | +- org.apache.httpcomponents:httpcore:jar:4.1.2:compile
[INFO] | | \- com.jamesmurty.utils:java-xmlbuilder:jar:0.4:compile
```
This change moves both `httpclient` and `httpcore` to our root pom dependency management section, which makes `net.java.dev.jets3t:jets3t:jar` pull in the 4.2 version. This has been tested on the named EMR version.
If there is a new RC, we should merge this. I don't think that we have to cancel an ongoing RC. We can add it to 0.10.1.
Thanks for @tillrohrmann for spotting a crucial client vs. core typo, which was driving me nuts while testing the change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink http
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1301
----
commit 2ae9d03b5f78135ab619e704d5fddfa30e98ef6f
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-10-26T14:34:58Z
Add org.apache.httpcomponents:(httpcore, httpclient) to dependency management
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Add org.apache.httpcomponents:(httpcore, httpc...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1301#issuecomment-151559475
@mxm, Can you look at this for the next RC?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Add org.apache.httpcomponents:(httpcore, httpc...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1301#issuecomment-151577309
+1 looks good. will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Add org.apache.httpcomponents:(httpcore, httpc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---