You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/28 05:21:41 UTC
[GitHub] [kylin] zhoukangcn opened a new pull request #1170: KYLIN-4437 repalce deprecated mapred.job.name & set cube in hive mr …
zhoukangcn opened a new pull request #1170: KYLIN-4437 repalce deprecated mapred.job.name & set cube in hive mr …
URL: https://github.com/apache/kylin/pull/1170
…name
## Proposed changes
see: https://issues.apache.org/jira/browse/KYLIN-4437
mapred.job.name is deprecated. Change to mapreduce.job.name is better.
add cube name and job id in MR job name, could help admins to find the job in yarn cluster.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1170: KYLIN-4437 repalce deprecated mapred.job.name & set cube in hive mr …
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1170: KYLIN-4437 repalce deprecated mapred.job.name & set cube in hive mr …
URL: https://github.com/apache/kylin/pull/1170#issuecomment-605403465
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1170?src=pr&el=h1) Report
> Merging [#1170](https://codecov.io/gh/apache/kylin/pull/1170?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/9cc3793ab2f2f0053c467a9b3f38cb7791cd436a&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `12.01%`.
[](https://codecov.io/gh/apache/kylin/pull/1170?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1170 +/- ##
============================================
- Coverage 25.04% 25.01% -0.04%
- Complexity 6247 6251 +4
============================================
Files 1446 1449 +3
Lines 88314 88492 +178
Branches 12358 12372 +14
============================================
+ Hits 22121 22135 +14
- Misses 64018 64181 +163
- Partials 2175 2176 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1170?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.26% <0.00%> (ø)` | `44.00 <0.00> (ø)` | |
| [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `14.56% <ø> (ø)` | `10.00 <0.00> (ø)` | |
| [...in/java/org/apache/kylin/common/util/ToolUtil.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL1Rvb2xVdGlsLmphdmE=) | `10.63% <ø> (+1.54%)` | `2.00 <0.00> (ø)` | |
| [...ain/java/org/apache/kylin/engine/mr/CubingJob.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQ3ViaW5nSm9iLmphdmE=) | `1.53% <0.00%> (-0.04%)` | `2.00 <0.00> (ø)` | |
| [...che/kylin/engine/mr/steps/CreateDictionaryJob.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ3JlYXRlRGljdGlvbmFyeUpvYi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...rg/apache/kylin/rest/service/DiagnosisService.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9EaWFnbm9zaXNTZXJ2aWNlLmphdmE=) | `26.78% <0.00%> (ø)` | `6.00 <0.00> (ø)` | |
| [...che/kylin/source/hive/CreateFlatHiveTableStep.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NyZWF0ZUZsYXRIaXZlVGFibGVTdGVwLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...lin/source/hive/RedistributeFlatHiveTableStep.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL1JlZGlzdHJpYnV0ZUZsYXRIaXZlVGFibGVTdGVwLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/kylin/pull/1170/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1170?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1170?src=pr&el=footer). Last update [e16a4be...50ef9ec](https://codecov.io/gh/apache/kylin/pull/1170?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1170: KYLIN-4437 repalce deprecated mapred.job.name & set cube in hive mr …
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1170: KYLIN-4437 repalce deprecated mapred.job.name & set cube in hive mr …
URL: https://github.com/apache/kylin/pull/1170
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services