[jira] [Commented] (OFBIZ-10389) The first visit event are not executed in case of CMS

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459729#comment-16459729 ] 

Jacques Le Roux commented on OFBIZ-10389:
-----------------------------------------

Hi Swapnil,

This seems good to me, but should we not also handle cases like /cmssite/cms/APACHE_OFBIZ_HTML because then uriString == null. Not sure it's really needed for this case but there are maybe others alike (with not only /cmssite/cms/ but something after)

> The first visit event are not executed in case of CMS
> -----------------------------------------------------
>
>                 Key: OFBIZ-10389
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10389
>             Project: OFBiz
>          Issue Type: Bug
>          Components: cmssite
>    Affects Versions: Trunk
>            Reporter: Swapnil M Mane
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: OFBIZ-10389.patch
>
>
> Execution of the first visit events depends on the trackVisit function
> In ofbiz/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java file
> {code}
> if (this.trackVisit(request) && session.getAttribute("_FIRST_VISIT_EVENTS_") == null) {
>     // execute first visit event
> }
> {code}
> trackVisit function does not honor the default controller request (in this case, cms)
> So, we should improve the code of trackVisit to honor default controller request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)