You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/10/08 19:15:24 UTC
[GitHub] [accumulo] jmark99 opened a new pull request #1729: Update regex expression in tool.sh
jmark99 opened a new pull request #1729:
URL: https://github.com/apache/accumulo/pull/1729
Modify the regex in tool.sh to successfully determine zookeeper version. Previous commit needed to be slightly modified to work correctly. Replacing ^3[.][01234].*$ with .*-3[.][01234].*$
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1729: Update regex expression in tool.sh
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1729:
URL: https://github.com/apache/accumulo/pull/1729#discussion_r502004569
##########
File path: assemble/bin/tool.sh
##########
@@ -38,7 +38,7 @@ fi
ZOOKEEPER_CMD='ls -1 $ZOOKEEPER_HOME/lib/zookeeper-[0-9]*[^csn].jar '
ZOOKEEPER_VERSION=$(find -L "$ZOOKEEPER_HOME" -maxdepth 2 -name "zookeeper-[0-9]*.jar" | head -1)
-if [[ $ZOOKEEPER_VERSION =~ ^3[.][01234].*$ ]]; then
+if [[ $ZOOKEEPER_VERSION =~ .*-3[.][01234].*$ ]]; then
Review comment:
How about this?
```suggestion
if [[ $ZOOKEEPER_VERSION =~ ^.*zookeeper-3[.][01234].*$ ]]; then
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1729: Update regex expression in tool.sh
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1729:
URL: https://github.com/apache/accumulo/pull/1729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1729: Update regex expression in tool.sh
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1729:
URL: https://github.com/apache/accumulo/pull/1729#discussion_r502004569
##########
File path: assemble/bin/tool.sh
##########
@@ -38,7 +38,7 @@ fi
ZOOKEEPER_CMD='ls -1 $ZOOKEEPER_HOME/lib/zookeeper-[0-9]*[^csn].jar '
ZOOKEEPER_VERSION=$(find -L "$ZOOKEEPER_HOME" -maxdepth 2 -name "zookeeper-[0-9]*.jar" | head -1)
-if [[ $ZOOKEEPER_VERSION =~ ^3[.][01234].*$ ]]; then
+if [[ $ZOOKEEPER_VERSION =~ .*-3[.][01234].*$ ]]; then
Review comment:
How about this?
```suggestion
if [[ $ZOOKEEPER_VERSION =~ ^.*zookeeper-3[.][01234].*$ ]]; then
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org