You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:23:01 UTC
[GitHub] [arrow-datafusion] jgoday opened a new pull request #544: Not equal predicate in physical_planning pruning
jgoday opened a new pull request #544:
URL: https://github.com/apache/arrow-datafusion/pull/544
# Which issue does this PR close?
Closes #420.
# Rationale for this change
Pruning not equal predicates if the value is between min and max bounds.
# What changes are included in this PR?
# Are there any user-facing changes?
Change datafusion/src/physical_optimizer/pruning.rs build_predicate_expression to include Operator::NotEq
and define test case 'row_group_predicate_not_eq'
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #544: Not equal predicate in physical_planning pruning
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #544:
URL: https://github.com/apache/arrow-datafusion/pull/544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #544: Not equal predicate in physical_planning pruning
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #544:
URL: https://github.com/apache/arrow-datafusion/pull/544#issuecomment-860882163
I think we got the logic slightly backwards here -- see https://github.com/apache/arrow-datafusion/issues/560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #544: Not equal predicate in physical_planning pruning
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #544:
URL: https://github.com/apache/arrow-datafusion/pull/544#issuecomment-860882163
I think we got the logic a bit too aggressive see -- see https://github.com/apache/arrow-datafusion/issues/560. FYI @jgoday
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #544: Not equal predicate in physical_planning pruning
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #544:
URL: https://github.com/apache/arrow-datafusion/pull/544#issuecomment-859933631
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#544](https://codecov.io/gh/apache/arrow-datafusion/pull/544?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4e91d9) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/ad70a1e91667174436f2110a70e3e557c7069e9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad70a1e) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
+ Coverage 76.13% 76.15% +0.01%
==========================================
Files 156 156
Lines 27032 27047 +15
==========================================
+ Hits 20582 20597 +15
Misses 6450 6450
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/src/physical\_optimizer/pruning.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/544/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvcGh5c2ljYWxfb3B0aW1pemVyL3BydW5pbmcucnM=) | `92.52% <100.00%> (+0.24%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/544?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/544?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ad70a1e...c4e91d9](https://codecov.io/gh/apache/arrow-datafusion/pull/544?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #544: Not equal predicate in physical_planning pruning
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #544:
URL: https://github.com/apache/arrow-datafusion/pull/544#issuecomment-860882163
I think we got the logic slightly backwards here -- see https://github.com/apache/arrow-datafusion/issues/560. FYI @jgoday
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org