You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/06/06 08:04:14 UTC
[kudu-CR] fuzz-itest: assorted cleanup
Hello Will Berkeley, Mike Percy, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13532
to review the following change.
Change subject: fuzz-itest: assorted cleanup
......................................................................
fuzz-itest: assorted cleanup
No functional changes here, though this does change the textual
representation of a fuzz-itest op.
Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 144 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13532/1
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13532 )
Change subject: fuzz-itest: assorted cleanup
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 12:34:33 +0000
Gerrit-HasComments: No
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13532 )
Change subject: fuzz-itest: assorted cleanup
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13532/1/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:
http://gerrit.cloudera.org:8080/#/c/13532/1/src/kudu/integration-tests/fuzz-itest.cc@146
PS1, Line 146: val2(v2) {}
> error: multiple initializations given for non-static member 'val' [clang-di
What is val2 here?
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 13:13:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13532 )
Change subject: fuzz-itest: assorted cleanup
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13532/1/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:
http://gerrit.cloudera.org:8080/#/c/13532/1/src/kudu/integration-tests/fuzz-itest.cc@146
PS1, Line 146:
> What is val2 here?
That was a mistake; it shows up for real in a future patch.
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 17:30:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13532 )
Change subject: fuzz-itest: assorted cleanup
......................................................................
fuzz-itest: assorted cleanup
No functional changes here, though this does change the textual
representation of a fuzz-itest op.
Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Reviewed-on: http://gerrit.cloudera.org:8080/13532
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 142 insertions(+), 116 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13532 )
Change subject: fuzz-itest: assorted cleanup
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13532/2/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:
http://gerrit.cloudera.org:8080/#/c/13532/2/src/kudu/integration-tests/fuzz-itest.cc@118
PS2, Line 118: TEST_DIFF_SCAN,
accidental inclusion? it's missing in the string names and the switch
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 22:51:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13532 )
Change subject: fuzz-itest: assorted cleanup
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13532/2/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:
http://gerrit.cloudera.org:8080/#/c/13532/2/src/kudu/integration-tests/fuzz-itest.cc@118
PS2, Line 118: TEST_DIFF_SCAN,
> accidental inclusion? it's missing in the string names and the switch
Indeed. I'll move it to the appropriate patch.
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 05:52:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13532
to look at the new patch set (#2).
Change subject: fuzz-itest: assorted cleanup
......................................................................
fuzz-itest: assorted cleanup
No functional changes here, though this does change the textual
representation of a fuzz-itest op.
Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 143 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13532/2
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13532 )
Change subject: fuzz-itest: assorted cleanup
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 20:27:42 +0000
Gerrit-HasComments: No
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13532
to look at the new patch set (#3).
Change subject: fuzz-itest: assorted cleanup
......................................................................
fuzz-itest: assorted cleanup
No functional changes here, though this does change the textual
representation of a fuzz-itest op.
Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
---
M src/kudu/integration-tests/fuzz-itest.cc
1 file changed, 142 insertions(+), 116 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13532/3
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] fuzz-itest: assorted cleanup
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13532 )
Change subject: fuzz-itest: assorted cleanup
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13532
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1792f4f2d83403c9ae57acb29190246d5f036e69
Gerrit-Change-Number: 13532
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 07:02:54 +0000
Gerrit-HasComments: No