You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by ra...@apache.org on 2014/05/06 10:54:58 UTC

svn commit: r1592687 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java

Author: ragerri
Date: Tue May  6 08:54:58 2014
New Revision: 1592687

URL: http://svn.apache.org/r1592687
Log:
removing language specific casting for headrules from treeinsert parser

Modified:
    opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java

Modified: opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java
URL: http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java?rev=1592687&r1=1592686&r2=1592687&view=diff
==============================================================================
--- opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java (original)
+++ opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java Tue May  6 08:54:58 2014
@@ -486,7 +486,7 @@ public class Parser extends AbstractBott
     // TODO: Remove cast for HeadRules
     return new ParserModel(languageCode, buildModel, checkModel,
         attachModel, posModel, chunkModel,
-        (opennlp.tools.parser.lang.en.HeadRules) rules, ParserType.TREEINSERT, manifestInfoEntries);
+        (opennlp.tools.parser.HeadRules) rules, ParserType.TREEINSERT, manifestInfoEntries);
   }
 
   public static ParserModel train(String languageCode,

Re: svn commit: r1592687 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java

Posted by Jörn Kottmann <ko...@gmail.com>.
Hello,

at OpenNLP all commit logs should contain the issue for which the code
was checked in.

Please include the issue number in all your future commits. We only make
exceptions for very trivial commits, e.g. spell correction in a comment,
or for the website.

Jörn

On Tue, 2014-05-06 at 08:54 +0000, ragerri@apache.org wrote:
> Author: ragerri
> Date: Tue May  6 08:54:58 2014
> New Revision: 1592687
> 
> URL: http://svn.apache.org/r1592687
> Log:
> removing language specific casting for headrules from treeinsert parser
> 
> Modified:
>     opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java
> 
> Modified: opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java
> URL: http://svn.apache.org/viewvc/opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java?rev=1592687&r1=1592686&r2=1592687&view=diff
> ==============================================================================
> --- opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java (original)
> +++ opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/parser/treeinsert/Parser.java Tue May  6 08:54:58 2014
> @@ -486,7 +486,7 @@ public class Parser extends AbstractBott
>      // TODO: Remove cast for HeadRules
>      return new ParserModel(languageCode, buildModel, checkModel,
>          attachModel, posModel, chunkModel,
> -        (opennlp.tools.parser.lang.en.HeadRules) rules, ParserType.TREEINSERT, manifestInfoEntries);
> +        (opennlp.tools.parser.HeadRules) rules, ParserType.TREEINSERT, manifestInfoEntries);
>    }
>  
>    public static ParserModel train(String languageCode,
> 
>