You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by db...@apache.org on 2015/07/14 05:58:29 UTC
svn commit: r1690861 -
/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java
Author: dbrosius
Date: Tue Jul 14 03:58:28 2015
New Revision: 1690861
URL: http://svn.apache.org/r1690861
Log:
fix typo in equals which did not validate that parm was of right type
Modified:
jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java
Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java?rev=1690861&r1=1690860&r2=1690861&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java Tue Jul 14 03:58:28 2015
@@ -722,7 +722,7 @@ public class SelectorImpl extends Source
public boolean equals(Object other) {
if (this == other) {
return true;
- } else if (!(this instanceof SelectorImpl)) {
+ } else if (!(other instanceof SelectorImpl)) {
return false;
}
return selectorName.equals(((SelectorImpl) other).selectorName);
Re: svn commit: r1690861 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java
Posted by Chetan Mehrotra <ch...@gmail.com>.
If this looks like a bug (which it appears to be) then it would be
better if we create an issue for this and have that merged to branches
also
Chetan Mehrotra
On Tue, Jul 14, 2015 at 9:28 AM, <db...@apache.org> wrote:
> Author: dbrosius
> Date: Tue Jul 14 03:58:28 2015
> New Revision: 1690861
>
> URL: http://svn.apache.org/r1690861
> Log:
> fix typo in equals which did not validate that parm was of right type
>
> Modified:
> jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java
>
> Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java
> URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java?rev=1690861&r1=1690860&r2=1690861&view=diff
> ==============================================================================
> --- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java (original)
> +++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java Tue Jul 14 03:58:28 2015
> @@ -722,7 +722,7 @@ public class SelectorImpl extends Source
> public boolean equals(Object other) {
> if (this == other) {
> return true;
> - } else if (!(this instanceof SelectorImpl)) {
> + } else if (!(other instanceof SelectorImpl)) {
> return false;
> }
> return selectorName.equals(((SelectorImpl) other).selectorName);
>
>