You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Nitesh Maheshwari (Jira)" <ji...@apache.org> on 2019/12/29 01:55:00 UTC
[jira] [Updated] (PHOENIX-5654) String values (ALWAYS and NEVER)
don't work for connection level config
phoenix.default.update.cache.frequency
[ https://issues.apache.org/jira/browse/PHOENIX-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitesh Maheshwari updated PHOENIX-5654:
---------------------------------------
Description:
While working on PHOENIX-5634, I noticed that the connection level property 'phoenix.default.update.cache.frequency' is being read in 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as follows:
{code:java}
long updateCacheFrequency = connection.getQueryServices().getProps().getLong(
QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
{code}
However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' at [https://phoenix.apache.org/language/index.html], the value for this config could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property should also follow the way the table-level property is read in 'TableProperty.UPDATE_CACHE_FREQUENCY'.
was:
While working on PHOENIX-5634, I noticed that the connection level property `phoenix.default.update.cache.frequency` is being read in `MetadataClient::createTable()` and `Metadata::createTableInternal()` as follows:
{code:java}
long updateCacheFrequency = connection.getQueryServices().getProps().getLong(
QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
{code}
However, looking at the documentation for option `UPDATE_CACHE_FREQUENCY` at [https://phoenix.apache.org/language/index.html], the value for this config could also be set to strings `ALWAYS` and `NEVER`. The use of getLong() above will always return `QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY` when the config is set to `ALWAYS`/`NEVER`. Reading the connection-level property should also follow the way the table-level property is read in `TableProperty.UPDATE_CACHE_FREQUENCY`.
> String values (ALWAYS and NEVER) don't work for connection level config phoenix.default.update.cache.frequency
> --------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5654
> URL: https://issues.apache.org/jira/browse/PHOENIX-5654
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0
> Reporter: Nitesh Maheshwari
> Assignee: Nitesh Maheshwari
> Priority: Major
> Fix For: 4.15.1
>
>
> While working on PHOENIX-5634, I noticed that the connection level property 'phoenix.default.update.cache.frequency' is being read in 'MetadataClient::createTable()' and 'Metadata::createTableInternal()' as follows:
> {code:java}
> long updateCacheFrequency = connection.getQueryServices().getProps().getLong(
> QueryServices.DEFAULT_UPDATE_CACHE_FREQUENCY_ATRRIB, QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY);
> {code}
> However, looking at the documentation for option 'UPDATE_CACHE_FREQUENCY' at [https://phoenix.apache.org/language/index.html], the value for this config could also be set to strings 'ALWAYS' and 'NEVER'. The use of getLong() above will always return 'QueryServicesOptions.DEFAULT_UPDATE_CACHE_FREQUENCY' when the config is set to 'ALWAYS'/'NEVER'. Reading the connection-level property should also follow the way the table-level property is read in 'TableProperty.UPDATE_CACHE_FREQUENCY'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)