You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/13 09:26:27 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request #13738: Fix wrong default value of expireTimeOfIncompleteChunkedMessage.
RobertIndie opened a new pull request #13738:
URL: https://github.com/apache/pulsar/pull/13738
### Motivation
Currently, the default value of expireTimeOfIncompleteChunkedMessage in ConsumerConfigurationData is incorrect. The [documentation](https://pulsar.apache.org/api/client/2.9.0-SNAPSHOT/org/apache/pulsar/client/api/ConsumerBuilder.html#expireTimeOfIncompleteChunkedMessage-long-java.util.concurrent.TimeUnit-) says the default value is one hour, but it is actually one minute.
### Modifications
* Fix the wrong default value of expireTimeOfIncompleteChunkedMessage.
* Some fix on the expireTimeOfIncompleteChunkedMessage link comments.
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (yes)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Need to update docs?
- [x] `no-need-doc`
Fix the code to make it align with the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a change in pull request #13738: Fix wrong default value of expireTimeOfIncompleteChunkedMessage.
Posted by GitBox <gi...@apache.org>.
mattisonchao commented on a change in pull request #13738:
URL: https://github.com/apache/pulsar/pull/13738#discussion_r784524482
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java
##########
@@ -114,7 +114,7 @@ public int getMaxPendingChuckedMessage() {
private boolean autoAckOldestChunkedMessageOnQueueFull = false;
- private long expireTimeOfIncompleteChunkedMessageMillis = 60 * 1000;
+ private long expireTimeOfIncompleteChunkedMessageMillis = TimeUnit.HOURS.toMillis(1);
Review comment:
+1 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on a change in pull request #13738: Fix wrong default value of expireTimeOfIncompleteChunkedMessage.
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on a change in pull request #13738:
URL: https://github.com/apache/pulsar/pull/13738#discussion_r791429174
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java
##########
@@ -114,7 +114,7 @@ public int getMaxPendingChuckedMessage() {
private boolean autoAckOldestChunkedMessageOnQueueFull = false;
- private long expireTimeOfIncompleteChunkedMessageMillis = 60 * 1000;
+ private long expireTimeOfIncompleteChunkedMessageMillis = TimeUnit.HOURS.toMillis(1);
Review comment:
+1 for updating the doc. If there are no other objections, I will update the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on a change in pull request #13738: Fix wrong default value of expireTimeOfIncompleteChunkedMessage.
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on a change in pull request #13738:
URL: https://github.com/apache/pulsar/pull/13738#discussion_r791429174
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java
##########
@@ -114,7 +114,7 @@ public int getMaxPendingChuckedMessage() {
private boolean autoAckOldestChunkedMessageOnQueueFull = false;
- private long expireTimeOfIncompleteChunkedMessageMillis = 60 * 1000;
+ private long expireTimeOfIncompleteChunkedMessageMillis = TimeUnit.HOURS.toMillis(1);
Review comment:
+1 for updating the doc. If there are no other objections, I will update the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #13738: [Doc] Fix doc for wrong default value of expireTimeOfIncompleteChunkedMessage.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13738:
URL: https://github.com/apache/pulsar/pull/13738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #13738: Fix wrong default value of expireTimeOfIncompleteChunkedMessage.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #13738:
URL: https://github.com/apache/pulsar/pull/13738#discussion_r783815137
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ConsumerConfigurationData.java
##########
@@ -114,7 +114,7 @@ public int getMaxPendingChuckedMessage() {
private boolean autoAckOldestChunkedMessageOnQueueFull = false;
- private long expireTimeOfIncompleteChunkedMessageMillis = 60 * 1000;
+ private long expireTimeOfIncompleteChunkedMessageMillis = TimeUnit.HOURS.toMillis(1);
Review comment:
I think we should update the doc. 1 hour is too long for most cases. @merlimat @rdhabalia Please help confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #13738: [Doc] Fix doc for wrong default value of expireTimeOfIncompleteChunkedMessage.
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #13738:
URL: https://github.com/apache/pulsar/pull/13738#issuecomment-1021810253
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org