[GitHub] [iceberg] rdblue commented on a change in pull request #2275: Core: add schema id to snapshot and history entry

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2275:
URL: https://github.com/apache/iceberg/pull/2275#discussion_r604537121



##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -127,10 +127,16 @@ static TableMetadata newTableMetadata(Schema schema,
   public static class SnapshotLogEntry implements HistoryEntry {
     private final long timestampMillis;
     private final long snapshotId;
+    private final Integer schemaId;
 
-    SnapshotLogEntry(long timestampMillis, long snapshotId) {
+    SnapshotLogEntry(long timestampMillis, long snapshotId, Integer schemaId) {

Review comment:
       Why add the schema ID to the snapshot log as well as the snapshot? The snapshots in the log are all available in table metadata, so it doesn't seem like there is a benefit to adding it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org