You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/01/04 20:47:24 UTC
[GitHub] [nifi] bbende opened a new pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
bbende opened a new pull request #5630:
URL: https://github.com/apache/nifi/pull/5630
- Switch ExtensionManifestParser impl to use JAXB instead of Jackson XML
- Fix handling of older NARs that don't have newer fields in ExtensionManifest
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#issuecomment-1018602692
@exceptionfactory any chance you can take another pass at this? I think I have addressed the previous comments with the latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r778855723
##########
File path: nifi-manifest/nifi-extension-manifest-parser/pom.xml
##########
@@ -29,11 +29,23 @@
<artifactId>nifi-extension-manifest-model</artifactId>
<version>1.16.0-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
Review comment:
Is there a particular reason for switching from Jackson XML to JAXB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r783357953
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
##########
@@ -564,6 +577,62 @@ private boolean implementsServiceType(final Class serviceType, final Class type)
return dtoFactory.fromDocumentedTypes(getExtensionManager().getExtensions(ReportingTask.class), bundleGroupFilter, bundleArtifactFilter, typeFilter);
}
+
+ /**
+ * Gets the RuntimeManifest for this overall NiFi instance.
+ *
+ * @return the runtime manifest
+ */
+ public RuntimeManifest getRuntimeManifest() {
+ final ExtensionManager extensionManager = getExtensionManager();
+ final Set<Bundle> allBundles = extensionManager.getAllBundles();
+
+ final Bundle frameworkBundle = NarClassLoadersHolder.getInstance().getFrameworkBundle();
+ final BundleDetails frameworkDetails = frameworkBundle.getBundleDetails();
+ final Date frameworkBuildDate = frameworkDetails.getBuildTimestampDate();
+
+ final BuildInfo buildInfo = new BuildInfo();
+ buildInfo.setVersion(frameworkDetails.getCoordinate().getVersion());
+ buildInfo.setRevision(frameworkDetails.getBuildRevision());
+ buildInfo.setCompiler(frameworkDetails.getBuildJdk());
+ buildInfo.setTimestamp(frameworkBuildDate == null ? null : frameworkBuildDate.getTime());
+
+ final RuntimeManifestBuilder manifestBuilder = new StandardRuntimeManifestBuilder()
+ .identifier("nifi")
+ .runtimeType("nifi")
+ .version(buildInfo.getVersion())
+ .schedulingDefaults(SchedulingDefaultsFactory.getNifiSchedulingDefaults())
+ .buildInfo(buildInfo);
+
+ for (final Bundle bundle : allBundles) {
+ getExtensionManifest(bundle).ifPresent(em -> manifestBuilder.addBundle(em));
+ }
+
+ return manifestBuilder.build();
+ }
+
+ private Optional<ExtensionManifest> getExtensionManifest(final Bundle bundle) {
+ final BundleDetails bundleDetails = bundle.getBundleDetails();
+ final File manifestFile = new File(bundleDetails.getWorkingDirectory(), "META-INF/docs/extension-manifest.xml");
+ if (!manifestFile.exists()) {
+ logger.warn("Unable to find extension manifest for [{}] at [{}]...", bundleDetails.getCoordinate(), manifestFile.getAbsolutePath());
+ return Optional.empty();
+ }
+
+ try (final InputStream inputStream = new FileInputStream(manifestFile)) {
+ final ExtensionManifest extensionManifest = extensionManifestParser.parse(inputStream);
+ // Newer NARs will have these fields populated in extension-manifest.xml, but older NARs will not, so we can
+ // set the values from the BundleCoordinate which already has the group, artifact id, and version
+ extensionManifest.setGroupId(bundleDetails.getCoordinate().getGroup());
+ extensionManifest.setArtifactId(bundleDetails.getCoordinate().getId());
+ extensionManifest.setVersion(bundleDetails.getCoordinate().getVersion());
+ return Optional.of(extensionManifest);
+ } catch (final IOException e) {
+ logger.error("Unable to load extension manifest for: " + bundleDetails.getCoordinate(), e);
Review comment:
This should be changed to use placeholder variables:
```suggestion
logger.error("Unable to load extension manifest for bundle {}", bundleDetails.getCoordinate(), e);
```
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java
##########
@@ -1358,6 +1359,41 @@ public Response getReportingTaskTypes(
return generateOkResponse(entity).build();
}
+ @GET
+ @Consumes(MediaType.WILDCARD)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("runtime-manifest")
+ @ApiOperation(
+ value = "Retrieves the runtime manifest for this NiFi instance.",
+ notes = NON_GUARANTEED_ENDPOINT,
+ response = RuntimeManifest.class,
+ authorizations = {
+ @Authorization(value = "Read - /flow")
+ }
+ )
+ @ApiResponses(
+ value = {
+ @ApiResponse(code = 400, message = "NiFi was unable to complete the request because it was invalid. The request should not be retried without modification."),
+ @ApiResponse(code = 401, message = "Client could not be authenticated."),
+ @ApiResponse(code = 403, message = "Client is not authorized to make this request."),
+ @ApiResponse(code = 409, message = "The request was valid but NiFi was not in the appropriate state to process it. Retrying the same request later may be successful.")
+ }
+ )
+ public Response getRuntimeManifest() throws InterruptedException {
+
+ authorizeFlow();
+
+ if (isReplicateRequest()) {
+ return replicate(HttpMethod.GET);
+ }
Review comment:
Should this request be replicated to other cluster nodes?
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
##########
@@ -564,6 +577,62 @@ private boolean implementsServiceType(final Class serviceType, final Class type)
return dtoFactory.fromDocumentedTypes(getExtensionManager().getExtensions(ReportingTask.class), bundleGroupFilter, bundleArtifactFilter, typeFilter);
}
+
+ /**
+ * Gets the RuntimeManifest for this overall NiFi instance.
+ *
+ * @return the runtime manifest
+ */
+ public RuntimeManifest getRuntimeManifest() {
+ final ExtensionManager extensionManager = getExtensionManager();
+ final Set<Bundle> allBundles = extensionManager.getAllBundles();
+
+ final Bundle frameworkBundle = NarClassLoadersHolder.getInstance().getFrameworkBundle();
+ final BundleDetails frameworkDetails = frameworkBundle.getBundleDetails();
+ final Date frameworkBuildDate = frameworkDetails.getBuildTimestampDate();
+
+ final BuildInfo buildInfo = new BuildInfo();
+ buildInfo.setVersion(frameworkDetails.getCoordinate().getVersion());
+ buildInfo.setRevision(frameworkDetails.getBuildRevision());
+ buildInfo.setCompiler(frameworkDetails.getBuildJdk());
+ buildInfo.setTimestamp(frameworkBuildDate == null ? null : frameworkBuildDate.getTime());
+
+ final RuntimeManifestBuilder manifestBuilder = new StandardRuntimeManifestBuilder()
+ .identifier("nifi")
+ .runtimeType("nifi")
Review comment:
Is the value of `nifi` important for any other consuming service? What do you think about promoting the value to a static variable?
##########
File path: nifi-manifest/nifi-runtime-manifest-core/pom.xml
##########
@@ -44,5 +44,10 @@
<artifactId>nifi-extension-manifest-parser</artifactId>
<version>1.16.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-databind</artifactId>
Review comment:
Is this additional dependency necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r787778554
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java
##########
@@ -1358,6 +1359,41 @@ public Response getReportingTaskTypes(
return generateOkResponse(entity).build();
}
+ @GET
+ @Consumes(MediaType.WILDCARD)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("runtime-manifest")
+ @ApiOperation(
+ value = "Retrieves the runtime manifest for this NiFi instance.",
+ notes = NON_GUARANTEED_ENDPOINT,
+ response = RuntimeManifest.class,
+ authorizations = {
+ @Authorization(value = "Read - /flow")
+ }
+ )
+ @ApiResponses(
+ value = {
+ @ApiResponse(code = 400, message = "NiFi was unable to complete the request because it was invalid. The request should not be retried without modification."),
+ @ApiResponse(code = 401, message = "Client could not be authenticated."),
+ @ApiResponse(code = 403, message = "Client is not authorized to make this request."),
+ @ApiResponse(code = 409, message = "The request was valid but NiFi was not in the appropriate state to process it. Retrying the same request later may be successful.")
+ }
+ )
+ public Response getRuntimeManifest() throws InterruptedException {
+
+ authorizeFlow();
+
+ if (isReplicateRequest()) {
+ return replicate(HttpMethod.GET);
+ }
Review comment:
I debated about this, but I based it off the end-points that are currently used to retrieve available types for processors/controller-services/reporting-tasks, and since those don't replicate, I figured it was ok to leave this one not replicating until we come up with a good reason that it needs to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r778858154
##########
File path: nifi-manifest/nifi-extension-manifest-parser/pom.xml
##########
@@ -29,11 +29,23 @@
<artifactId>nifi-extension-manifest-model</artifactId>
<version>1.16.0-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
Review comment:
Yes, this module needs to be used from the framework and jackson-dataformat-xml brings in transitive dependency for woodstox which then gets found as an XML provider for other things that it wasn't intended to be found for. Using JAX-B seemed like a simpler approach since everything is already setup for it being available on the classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r778862983
##########
File path: nifi-manifest/nifi-extension-manifest-parser/pom.xml
##########
@@ -29,11 +29,23 @@
<artifactId>nifi-extension-manifest-model</artifactId>
<version>1.16.0-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
Review comment:
Thanks for the background, switching to JAX-B sounds like the best approach given the other dependencies you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r787777435
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
##########
@@ -564,6 +577,62 @@ private boolean implementsServiceType(final Class serviceType, final Class type)
return dtoFactory.fromDocumentedTypes(getExtensionManager().getExtensions(ReportingTask.class), bundleGroupFilter, bundleArtifactFilter, typeFilter);
}
+
+ /**
+ * Gets the RuntimeManifest for this overall NiFi instance.
+ *
+ * @return the runtime manifest
+ */
+ public RuntimeManifest getRuntimeManifest() {
+ final ExtensionManager extensionManager = getExtensionManager();
+ final Set<Bundle> allBundles = extensionManager.getAllBundles();
+
+ final Bundle frameworkBundle = NarClassLoadersHolder.getInstance().getFrameworkBundle();
+ final BundleDetails frameworkDetails = frameworkBundle.getBundleDetails();
+ final Date frameworkBuildDate = frameworkDetails.getBuildTimestampDate();
+
+ final BuildInfo buildInfo = new BuildInfo();
+ buildInfo.setVersion(frameworkDetails.getCoordinate().getVersion());
+ buildInfo.setRevision(frameworkDetails.getBuildRevision());
+ buildInfo.setCompiler(frameworkDetails.getBuildJdk());
+ buildInfo.setTimestamp(frameworkBuildDate == null ? null : frameworkBuildDate.getTime());
+
+ final RuntimeManifestBuilder manifestBuilder = new StandardRuntimeManifestBuilder()
+ .identifier("nifi")
+ .runtimeType("nifi")
Review comment:
It is not really that important for a consumer, mostly just metadata information, but I will promote it to a constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r787984172
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java
##########
@@ -1358,6 +1359,41 @@ public Response getReportingTaskTypes(
return generateOkResponse(entity).build();
}
+ @GET
+ @Consumes(MediaType.WILDCARD)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("runtime-manifest")
+ @ApiOperation(
+ value = "Retrieves the runtime manifest for this NiFi instance.",
+ notes = NON_GUARANTEED_ENDPOINT,
+ response = RuntimeManifest.class,
+ authorizations = {
+ @Authorization(value = "Read - /flow")
+ }
+ )
+ @ApiResponses(
+ value = {
+ @ApiResponse(code = 400, message = "NiFi was unable to complete the request because it was invalid. The request should not be retried without modification."),
+ @ApiResponse(code = 401, message = "Client could not be authenticated."),
+ @ApiResponse(code = 403, message = "Client is not authorized to make this request."),
+ @ApiResponse(code = 409, message = "The request was valid but NiFi was not in the appropriate state to process it. Retrying the same request later may be successful.")
+ }
+ )
+ public Response getRuntimeManifest() throws InterruptedException {
+
+ authorizeFlow();
+
+ if (isReplicateRequest()) {
+ return replicate(HttpMethod.GET);
+ }
Review comment:
I stand corrected about the existing "types" end-points, they do actually perform replication and response merging. The idea is to provide a consistent response to a client with the intersection of the types in case one node has some NARs that another node doesn't have.
I pushed another commit that adds a response merger for the runtime-manifest. Right now the logic is to just perform the intersection of the bundles based on their unique group-artifact-version. To test this you can run a cluster and remove a NAR from one of the nodes and it should no longer show up in the manifest response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r787784455
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java
##########
@@ -1358,6 +1359,41 @@ public Response getReportingTaskTypes(
return generateOkResponse(entity).build();
}
+ @GET
+ @Consumes(MediaType.WILDCARD)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("runtime-manifest")
+ @ApiOperation(
+ value = "Retrieves the runtime manifest for this NiFi instance.",
+ notes = NON_GUARANTEED_ENDPOINT,
+ response = RuntimeManifest.class,
+ authorizations = {
+ @Authorization(value = "Read - /flow")
+ }
+ )
+ @ApiResponses(
+ value = {
+ @ApiResponse(code = 400, message = "NiFi was unable to complete the request because it was invalid. The request should not be retried without modification."),
+ @ApiResponse(code = 401, message = "Client could not be authenticated."),
+ @ApiResponse(code = 403, message = "Client is not authorized to make this request."),
+ @ApiResponse(code = 409, message = "The request was valid but NiFi was not in the appropriate state to process it. Retrying the same request later may be successful.")
+ }
+ )
+ public Response getRuntimeManifest() throws InterruptedException {
+
+ authorizeFlow();
+
+ if (isReplicateRequest()) {
+ return replicate(HttpMethod.GET);
+ }
Review comment:
Thanks for the reply. Since it is a `GET` request, it seems reasonable that the request should not be replicated. To clarify, should this conditional block be removed since the request will not be replicated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r778862983
##########
File path: nifi-manifest/nifi-extension-manifest-parser/pom.xml
##########
@@ -29,11 +29,23 @@
<artifactId>nifi-extension-manifest-model</artifactId>
<version>1.16.0-SNAPSHOT</version>
</dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.dataformat</groupId>
- <artifactId>jackson-dataformat-xml</artifactId>
Review comment:
Thanks for the background, swithcing to JAX-B sounds like the best approach given the other dependencies you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on a change in pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
bbende commented on a change in pull request #5630:
URL: https://github.com/apache/nifi/pull/5630#discussion_r787776937
##########
File path: nifi-manifest/nifi-runtime-manifest-core/pom.xml
##########
@@ -44,5 +44,10 @@
<artifactId>nifi-extension-manifest-parser</artifactId>
<version>1.16.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-databind</artifactId>
Review comment:
Yes there is some code in this module that uses an ObjectMapper to serialize the manifest to JSON
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5630: NIFI-9501 Add REST end-point to retrieve a RuntimeManifest
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #5630:
URL: https://github.com/apache/nifi/pull/5630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org