You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/24 02:52:59 UTC

[GitHub] [flink] WeiZhong94 commented on a change in pull request #11884: [FLINK-17345][python][table] Support register and get Python UDF in Catalog.

WeiZhong94 commented on a change in pull request #11884:
URL: https://github.com/apache/flink/pull/11884#discussion_r414254201



##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogFunctionImpl.java
##########
@@ -67,6 +67,9 @@ public CatalogFunction copy() {
 
 	@Override
 	public boolean isGeneric() {
+		if (functionLanguage == FunctionLanguage.PYTHON) {

Review comment:
       Currently the Python UDF is always generic and can not be loaded via `Class.forName`. So just return true if the CatalogFunction is a Python UDF.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org