[jira] [Resolved] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

["Tzu-Li (Gordon) Tai (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tzu-Li (Gordon) Tai resolved FLINK-6493.
----------------------------------------
       Resolution: Fixed
    Fix Version/s: 1.3.3

Thanks for the contribution [~mingleizhang]!
Fixed in master via 875a1369c2ecfd721e3797f59f7ae29e7c522840.
Fixed in 1.3 via 856d44cdb6147970f0a5912652bedbfaf8f9ca33.

> Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()
> -------------------------------------------------------------------------
>
>                 Key: FLINK-6493
>                 URL: https://issues.apache.org/jira/browse/FLINK-6493
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>            Reporter: Ted Yu
>            Assignee: mingleizhang
>            Priority: Minor
>             Fix For: 1.4.0, 1.3.3
>
>
> {code}
>         && ((partitionStateSerializer == null && ((Snapshot) obj).getPartitionStateSerializer() == null)
>           || partitionStateSerializer.equals(((Snapshot) obj).getPartitionStateSerializer()))
>         && ((partitionStateSerializerConfigSnapshot == null && ((Snapshot) obj).getPartitionStateSerializerConfigSnapshot() == null)
>           || partitionStateSerializerConfigSnapshot.equals(((Snapshot) obj).getPartitionStateSerializerConfigSnapshot()));
> {code}
> The null check for partitionStateSerializer / partitionStateSerializerConfigSnapshot is in combination with another clause.
> This may lead to NPE in the partitionStateSerializer.equals() call.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)