You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/15 23:15:25 UTC

[GitHub] [superset] benjreinhart opened a new issue #15183: getChartDataRequest handling does not account for async query responses

benjreinhart opened a new issue #15183:
URL: https://github.com/apache/superset/issues/15183


   [`getChartDataRequest`](https://github.com/apache/superset/blob/7dc0cee5be33848f46e443fcf3181b605811945b/superset-frontend/src/chart/chartAction.js#L202) is currently used to grab data for charts in 6 places. However, three of those call sites do not account for the (different) response returned when the Global Async Queries feature is enabled.
   
   Here are the call sites (the checked ones appear to properly handle GAQ):
   
   - [X] [src/chart/chartAction.js#L392](https://github.com/apache/superset/blob/7dc0cee5be33848f46e443fcf3181b605811945b/superset-frontend/src/chart/chartAction.js#L392)
   - [ ] [src/chart/chartAction.js#L543](https://github.com/apache/superset/blob/7dc0cee5be33848f46e443fcf3181b605811945b/superset-frontend/src/chart/chartAction.js#L543)
   - [X] [src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx#L112](https://github.com/apache/superset/blob/7dc0cee5be33848f46e443fcf3181b605811945b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx#L112)
   - [X] [src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx#L368](https://github.com/apache/superset/blob/7dc0cee5be33848f46e443fcf3181b605811945b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx#L368)
   - [ ] [src/explore/components/controls/ViewQueryModal.tsx#L56](https://github.com/apache/superset/blob/7dc0cee5be33848f46e443fcf3181b605811945b/superset-frontend/src/explore/components/controls/ViewQueryModal.tsx#L56)
   - [ ] [src/explore/components/DataTablesPane/index.tsx#L146](https://github.com/apache/superset/blob/7dc0cee5be33848f46e443fcf3181b605811945b/superset-frontend/src/explore/components/DataTablesPane/index.tsx#L146)
   
   ### Expected results
   
   All call sites should be able to properly handle the async queries experience when the feature is enabled.
   
   ### Actual results
   
   Some actions, such as clicking "Run in SQL Lab," will not work properly when GAQ is enabled.
   
   ### Additional context
   
   Once https://github.com/apache/superset/pull/15157 is merged, all these call sites will need to additionally make sure they handle the synchronous response in addition to asynchronous response.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org