[jira] [Commented] (MYFACES-4408) Migrate all tests to JUnit5

["Melloware (Jira)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541467#comment-17541467 ] 

Melloware commented on MYFACES-4408:
------------------------------------

Is this still true?  I can't find this class anywhere in `master` that is `JUnit3Builder` ??

> Migrate all tests to JUnit5
> ---------------------------
>
>                 Key: MYFACES-4408
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4408
>             Project: MyFaces Core
>          Issue Type: Wish
>          Components: JSR-372
>    Affects Versions: 2.3-next-M6
>         Environment: junit 4.13.2, myfaces-test 2.3-next-M6
>            Reporter: Stanislav Pacvon
>            Priority: Minor
>
> JUnit38ClassRunner is used for tests when test classes extends AbstractJsfConfigurableMockTestCase. It is because AbstractJsfConfigurableMockTestCase extends TestCase and there is check in JUnit3Builder 
> {code:java}
> public class JUnit3Builder extends RunnerBuilder {
>     @Override
>     public Runner runnerForClass(Class<?> testClass) throws Throwable {
>         if (isPre4Test(testClass)) {
>             return new JUnit38ClassRunner(testClass);
>         }
>         return null;
>     }    boolean isPre4Test(Class<?> testClass) {
>         return junit.framework.TestCase.class.isAssignableFrom(testClass);
>     }
> }
> {code}
> Is it correct, that jsf tests have to run with Junit 3?



--
This message was sent by Atlassian Jira
(v8.20.7#820007)