[GitHub] [arrow] lidavidm commented on a change in pull request #11251: ARROW-13700: [Docs][C++] Clarify DayOfWeekOptions args

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #11251:
URL: https://github.com/apache/arrow/pull/11251#discussion_r719512364



##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -323,7 +323,8 @@ struct ARROW_EXPORT DayOfWeekOptions : public FunctionOptions {
 
   /// Number days from 0 if true and from 1 if false
   bool count_from_zero;
-  /// What day does the week start with (Monday=1, Sunday=7)
+  /// What day does the week start with (Monday=1, Sunday=7). This is unaffected
+  /// by the count_from_zero parameter.
   uint32_t week_start;

Review comment:
       Perhaps:
   
   ```
     /// Number output days from 0 if true and from 1 if false
     bool count_from_zero;
     /// What day does the week start with (Monday=1, Sunday=7).
     /// The numbering is unaffected by the count_from_zero parameter.
     uint32_t week_start;
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org