You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Leo Li <li...@gmail.com> on 2007/04/26 10:15:45 UTC
[classlib][beans]Excluded tests for beans module.
Hi, all:
I am looking at the testcases for beans module and I found that there
are a lot of testcases excluded. Is there any special reason that these
testcases are excluded? I have found several test failures but I think they
should be fixed, for example, the serialization problem and the
compatibility between sun and harmony.
I would like to look at these testcases and any volunteer?
Good luck!
--
Leo Li
China Software Development Lab, IBM
Re: [classlib][beans]Excluded tests for beans module.
Posted by Leo Li <li...@gmail.com>.
OK.:)
On 4/27/07, Alexey Varlamov <al...@gmail.com> wrote:
>
> 2007/4/27, Leo Li <li...@gmail.com>:
> > Hi, all:
> > When fixing bugs, I will add some regression tests. But if they are
> > appended to the original test files, they will still in the exclude
> list
> > since I can not fix all problems of a test file in one time. So I
> decide, if
> > no one objects, to add another test file, for example,
> > BeanContextSupport2Test, parallel with the original excluded
> > BeanContextSupportTest, to include the added regression ones in order
> to
> > ensure our future progress will not break something.:)
>
> Some people use XXXRTest naming pattern, it seems a bit more descriptive
> ;)
> i.e. BeanContextSupportRTest in your case
>
> >
> >
> > On 4/26/07, Alexei Zakharov <al...@gmail.com> wrote:
> > >
> > > Hi Leo,
> > >
> > > I've spent plenty of time in the past trying to enable all these beans
> > > tests. The main reason why they are excluded is the fact that they
> > > never pass. :) And nobody has enough time and energy to change this
> > > situation. Originally these tests and the code of java.beans package
> > > itself came from different contributions. And they really didn't fit
> > > each other well. Many tests check implementation details of some
> > > third-party's implementation that is neither Harmony nor RI. However,
> > > it much closer to RI than to Harmony. :) IMO the most tricky part are
> > > tests for XMLEncoder / XMLDecoder. Be prepared that you might need to
> > > significantly rework or even rewrite these classes in order to enable
> > > corresponding tests.
> > >
> > > However, if you like to start working on it - it's a good news. Go
> > > ahead! Don't hesitate to ask questions. I think I still remember
> > > something and most likely can answer simple questions. :)
> > > Good luck.
> > >
> > > 2007/4/26, Leo Li <li...@gmail.com>:
> > > > Hi, all:
> > > > I am looking at the testcases for beans module and I found that
> > > there
> > > > are a lot of testcases excluded. Is there any special reason that
> these
> > > > testcases are excluded? I have found several test failures but I
> think
> > > they
> > > > should be fixed, for example, the serialization problem and the
> > > > compatibility between sun and harmony.
> > > > I would like to look at these testcases and any volunteer?
> > > >
> > > > Good luck!
> > > > --
> > > > Leo Li
> > > > China Software Development Lab, IBM
> > > >
> > >
> > >
> > > --
> > > Alexei Zakharov,
> > > Intel ESSD
> > >
> >
> >
> >
> > --
> > Leo Li
> > China Software Development Lab, IBM
> >
>
--
Leo Li
China Software Development Lab, IBM
Re: [classlib][beans]Excluded tests for beans module.
Posted by Mikhail Loenko <ml...@gmail.com>.
I'd also prefer digit for the same reason
Thanks,
Mikhail
2007/4/27, Tim Ellison <t....@gmail.com>:
> Alexey Varlamov wrote:
> > 2007/4/27, Leo Li <li...@gmail.com>:
> >> Hi, all:
> >> When fixing bugs, I will add some regression tests. But if they are
> >> appended to the original test files, they will still in the exclude list
> >> since I can not fix all problems of a test file in one time. So I
> >> decide, if
> >> no one objects, to add another test file, for example,
> >> BeanContextSupport2Test, parallel with the original excluded
> >> BeanContextSupportTest, to include the added regression ones in order to
> >> ensure our future progress will not break something.:)
> >
> > Some people use XXXRTest naming pattern, it seems a bit more descriptive ;)
> > i.e. BeanContextSupportRTest in your case
>
> I think '2' is more readily recognized as additional tests than 'R'. I
> realise they are regression tests, but I don't see why they are called
> out as different to regular unit tests.
>
> Regards,
> Tim
>
>
Re: [classlib][beans]Excluded tests for beans module.
Posted by Tim Ellison <t....@gmail.com>.
Alexey Varlamov wrote:
> 2007/4/27, Leo Li <li...@gmail.com>:
>> Hi, all:
>> When fixing bugs, I will add some regression tests. But if they are
>> appended to the original test files, they will still in the exclude list
>> since I can not fix all problems of a test file in one time. So I
>> decide, if
>> no one objects, to add another test file, for example,
>> BeanContextSupport2Test, parallel with the original excluded
>> BeanContextSupportTest, to include the added regression ones in order to
>> ensure our future progress will not break something.:)
>
> Some people use XXXRTest naming pattern, it seems a bit more descriptive ;)
> i.e. BeanContextSupportRTest in your case
I think '2' is more readily recognized as additional tests than 'R'. I
realise they are regression tests, but I don't see why they are called
out as different to regular unit tests.
Regards,
Tim
Re: [classlib][beans]Excluded tests for beans module.
Posted by Alexey Varlamov <al...@gmail.com>.
2007/4/27, Leo Li <li...@gmail.com>:
> Hi, all:
> When fixing bugs, I will add some regression tests. But if they are
> appended to the original test files, they will still in the exclude list
> since I can not fix all problems of a test file in one time. So I decide, if
> no one objects, to add another test file, for example,
> BeanContextSupport2Test, parallel with the original excluded
> BeanContextSupportTest, to include the added regression ones in order to
> ensure our future progress will not break something.:)
Some people use XXXRTest naming pattern, it seems a bit more descriptive ;)
i.e. BeanContextSupportRTest in your case
>
>
> On 4/26/07, Alexei Zakharov <al...@gmail.com> wrote:
> >
> > Hi Leo,
> >
> > I've spent plenty of time in the past trying to enable all these beans
> > tests. The main reason why they are excluded is the fact that they
> > never pass. :) And nobody has enough time and energy to change this
> > situation. Originally these tests and the code of java.beans package
> > itself came from different contributions. And they really didn't fit
> > each other well. Many tests check implementation details of some
> > third-party's implementation that is neither Harmony nor RI. However,
> > it much closer to RI than to Harmony. :) IMO the most tricky part are
> > tests for XMLEncoder / XMLDecoder. Be prepared that you might need to
> > significantly rework or even rewrite these classes in order to enable
> > corresponding tests.
> >
> > However, if you like to start working on it - it's a good news. Go
> > ahead! Don't hesitate to ask questions. I think I still remember
> > something and most likely can answer simple questions. :)
> > Good luck.
> >
> > 2007/4/26, Leo Li <li...@gmail.com>:
> > > Hi, all:
> > > I am looking at the testcases for beans module and I found that
> > there
> > > are a lot of testcases excluded. Is there any special reason that these
> > > testcases are excluded? I have found several test failures but I think
> > they
> > > should be fixed, for example, the serialization problem and the
> > > compatibility between sun and harmony.
> > > I would like to look at these testcases and any volunteer?
> > >
> > > Good luck!
> > > --
> > > Leo Li
> > > China Software Development Lab, IBM
> > >
> >
> >
> > --
> > Alexei Zakharov,
> > Intel ESSD
> >
>
>
>
> --
> Leo Li
> China Software Development Lab, IBM
>
Re: [classlib][beans]Excluded tests for beans module.
Posted by Leo Li <li...@gmail.com>.
Hi, all:
When fixing bugs, I will add some regression tests. But if they are
appended to the original test files, they will still in the exclude list
since I can not fix all problems of a test file in one time. So I decide, if
no one objects, to add another test file, for example,
BeanContextSupport2Test, parallel with the original excluded
BeanContextSupportTest, to include the added regression ones in order to
ensure our future progress will not break something.:)
On 4/26/07, Alexei Zakharov <al...@gmail.com> wrote:
>
> Hi Leo,
>
> I've spent plenty of time in the past trying to enable all these beans
> tests. The main reason why they are excluded is the fact that they
> never pass. :) And nobody has enough time and energy to change this
> situation. Originally these tests and the code of java.beans package
> itself came from different contributions. And they really didn't fit
> each other well. Many tests check implementation details of some
> third-party's implementation that is neither Harmony nor RI. However,
> it much closer to RI than to Harmony. :) IMO the most tricky part are
> tests for XMLEncoder / XMLDecoder. Be prepared that you might need to
> significantly rework or even rewrite these classes in order to enable
> corresponding tests.
>
> However, if you like to start working on it - it's a good news. Go
> ahead! Don't hesitate to ask questions. I think I still remember
> something and most likely can answer simple questions. :)
> Good luck.
>
> 2007/4/26, Leo Li <li...@gmail.com>:
> > Hi, all:
> > I am looking at the testcases for beans module and I found that
> there
> > are a lot of testcases excluded. Is there any special reason that these
> > testcases are excluded? I have found several test failures but I think
> they
> > should be fixed, for example, the serialization problem and the
> > compatibility between sun and harmony.
> > I would like to look at these testcases and any volunteer?
> >
> > Good luck!
> > --
> > Leo Li
> > China Software Development Lab, IBM
> >
>
>
> --
> Alexei Zakharov,
> Intel ESSD
>
--
Leo Li
China Software Development Lab, IBM
Re: [classlib][beans]Excluded tests for beans module.
Posted by Alexei Zakharov <al...@gmail.com>.
Hi Leo,
I've spent plenty of time in the past trying to enable all these beans
tests. The main reason why they are excluded is the fact that they
never pass. :) And nobody has enough time and energy to change this
situation. Originally these tests and the code of java.beans package
itself came from different contributions. And they really didn't fit
each other well. Many tests check implementation details of some
third-party's implementation that is neither Harmony nor RI. However,
it much closer to RI than to Harmony. :) IMO the most tricky part are
tests for XMLEncoder / XMLDecoder. Be prepared that you might need to
significantly rework or even rewrite these classes in order to enable
corresponding tests.
However, if you like to start working on it - it's a good news. Go
ahead! Don't hesitate to ask questions. I think I still remember
something and most likely can answer simple questions. :)
Good luck.
2007/4/26, Leo Li <li...@gmail.com>:
> Hi, all:
> I am looking at the testcases for beans module and I found that there
> are a lot of testcases excluded. Is there any special reason that these
> testcases are excluded? I have found several test failures but I think they
> should be fixed, for example, the serialization problem and the
> compatibility between sun and harmony.
> I would like to look at these testcases and any volunteer?
>
> Good luck!
> --
> Leo Li
> China Software Development Lab, IBM
>
--
Alexei Zakharov,
Intel ESSD