You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2014/11/07 15:58:33 UTC
[jira] [Commented] (OAK-2259) SegmentBlob equals check should
verify compaction in both directions
[ https://issues.apache.org/jira/browse/OAK-2259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202112#comment-14202112 ]
Alex Parvulescu commented on OAK-2259:
--------------------------------------
fixed in trunk with rev http://svn.apache.org/r1637382
> SegmentBlob equals check should verify compaction in both directions
> --------------------------------------------------------------------
>
> Key: OAK-2259
> URL: https://issues.apache.org/jira/browse/OAK-2259
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segmentmk
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Fix For: 1.0.9, 1.1.3
>
>
> It looks like the SegmentNodeState checks compaction in one direction [0], while the SegmentBlob checks in the other direction. This will not break anything as the fallback is to use byte comparison, but it will be terribly slow.
> I'm proposing to verify both directions in the #equals check, to make sure we don't miss out.
> [0] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeState.java#L401
> [1] https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentBlob.java#L198
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)