You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ku...@apache.org on 2019/02/28 15:12:15 UTC

[carbondata] branch master updated: [CARBONDATA-3298]Removed Log Message for Already Deleted Segments

This is an automated email from the ASF dual-hosted git repository.

kunalkapoor pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git


The following commit(s) were added to refs/heads/master by this push:
     new 9051ab7  [CARBONDATA-3298]Removed Log Message for Already Deleted Segments
9051ab7 is described below

commit 9051ab72c141907375815599230c88d087030be0
Author: Indhumathi27 <in...@gmail.com>
AuthorDate: Tue Feb 19 18:20:40 2019 +0530

    [CARBONDATA-3298]Removed Log Message for Already Deleted Segments
    
    Problem:
    In old store, Create table and perform one Insert operation. Now,
    update and delete that record, which marks that segment as "MARKED FOR DELETE".
    Now run "clean files command" to delete the segment.
    Note: In this case, Metadata folder doesn't contain segment file.
    In new store, Refresh the table and again perform IUD operation. Now,
    when "clean files" command is executed, We will check if physically segment file
    exists or not, if not present, then we will log a warning message, as file not present.
    If old store contains more segments, then for each segment, this log message will be
    getting printed, which is not required.
    
    Solution:
    Removed log message for already deleted segments
    
    This closes #3131
---
 .../main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java  | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java b/core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java
index b614f55..21c504b 100644
--- a/core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java
+++ b/core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java
@@ -156,11 +156,7 @@ public final class DeleteLoadFolders {
                 }
               }
 
-            } else {
-              LOGGER.warn("Files are not found in segment " + path
-                  + " it seems, files are already being deleted");
             }
-
           }
           List<Segment> segments = new ArrayList<>(1);
           for (TableDataMap dataMap : indexDataMaps) {