You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by vm...@apache.org on 2002/05/17 14:55:36 UTC
cvs commit: jakarta-cactus/framework/src/java/share/org/apache/cactus/util Configuration.java
vmassol 02/05/17 05:55:35
Modified: framework build.xml
framework/src/java/share/org/apache/cactus
AbstractWebTestCase.java
framework/src/java/share/org/apache/cactus/server
AbstractWebTestCaller.java
framework/src/java/share/org/apache/cactus/util
Configuration.java
Log:
disabling new checkstyle enforcing rule on empty catch() blocks + implementing new recommandation of checsktyle for Boolean (but I believe checsktyle is wrong, I'm sending a bug report to them now).
Revision Changes Path
1.10 +1 -0 jakarta-cactus/framework/build.xml
Index: build.xml
===================================================================
RCS file: /home/cvs/jakarta-cactus/framework/build.xml,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- build.xml 22 Apr 2002 22:21:46 -0000 1.9
+++ build.xml 17 May 2002 12:55:35 -0000 1.10
@@ -455,6 +455,7 @@
ignoreWhitespace="false"
ignoreCastWhitespace="false"
ignoreBraces="false"
+ allowEmptyCatch="true"
failOnViolation="true"
cacheFile="${target.dir}/checkstyle.cache">
1.4 +2 -2 jakarta-cactus/framework/src/java/share/org/apache/cactus/AbstractWebTestCase.java
Index: AbstractWebTestCase.java
===================================================================
RCS file: /home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/AbstractWebTestCase.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- AbstractWebTestCase.java 12 May 2002 19:42:28 -0000 1.3
+++ AbstractWebTestCase.java 17 May 2002 12:55:35 -0000 1.4
@@ -72,7 +72,7 @@
*
* @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
*
- * @version $Id: AbstractWebTestCase.java,v 1.3 2002/05/12 19:42:28 vmassol Exp $
+ * @version $Id: AbstractWebTestCase.java,v 1.4 2002/05/17 12:55:35 vmassol Exp $
*/
public abstract class AbstractWebTestCase extends AbstractTestCase
{
@@ -246,7 +246,7 @@
request.addParameter(ServiceDefinition.METHOD_NAME_PARAM,
this.getCurrentTestMethod(), WebRequest.GET_METHOD);
request.addParameter(ServiceDefinition.AUTOSESSION_NAME_PARAM,
- new Boolean(request.getAutomaticSession()).toString(),
+ request.getAutomaticSession() ? "true" : "false",
WebRequest.GET_METHOD);
// Add the simulated URL (if one has been defined)
1.3 +2 -2 jakarta-cactus/framework/src/java/share/org/apache/cactus/server/AbstractWebTestCaller.java
Index: AbstractWebTestCaller.java
===================================================================
RCS file: /home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/server/AbstractWebTestCaller.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- AbstractWebTestCaller.java 12 May 2002 12:44:00 -0000 1.2
+++ AbstractWebTestCaller.java 17 May 2002 12:55:35 -0000 1.3
@@ -76,7 +76,7 @@
* @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
* @author <a href="mailto:ndlesiecki@apache.org">Nicholas Lesiecki</a>
*
- * @version $Id: AbstractWebTestCaller.java,v 1.2 2002/05/12 12:44:00 vmassol Exp $
+ * @version $Id: AbstractWebTestCaller.java,v 1.3 2002/05/17 12:55:35 vmassol Exp $
*/
public abstract class AbstractWebTestCaller
{
@@ -277,7 +277,7 @@
String autoSession = ServletUtil.getQueryStringParameter(queryString,
ServiceDefinition.AUTOSESSION_NAME_PARAM);
- boolean isAutomaticSession = new Boolean(autoSession).booleanValue();
+ boolean isAutomaticSession = Boolean.valueOf(autoSession).booleanValue();
LOGGER.debug("Auto session is " + isAutomaticSession);
1.4 +3 -3 jakarta-cactus/framework/src/java/share/org/apache/cactus/util/Configuration.java
Index: Configuration.java
===================================================================
RCS file: /home/cvs/jakarta-cactus/framework/src/java/share/org/apache/cactus/util/Configuration.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- Configuration.java 12 May 2002 19:41:14 -0000 1.3
+++ Configuration.java 17 May 2002 12:55:35 -0000 1.4
@@ -66,7 +66,7 @@
*
* @author <a href="mailto:vmassol@apache.org">Vincent Massol</a>
*
- * @version $Id: Configuration.java,v 1.3 2002/05/12 19:41:14 vmassol Exp $
+ * @version $Id: Configuration.java,v 1.4 2002/05/17 12:55:35 vmassol Exp $
*/
public class Configuration
{
@@ -140,7 +140,7 @@
*/
public static boolean isLoggingEnabled()
{
- return (new Boolean(getConfiguration().
- getString(ENABLE_LOGGING_PROPERTY)).booleanValue());
+ return Boolean.valueOf(getConfiguration().
+ getString(ENABLE_LOGGING_PROPERTY)).booleanValue();
}
}
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>