[jira] [Comment Edited] (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

["John McDonald (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487459#comment-13487459 ] 

John McDonald edited comment on OFBIZ-3883 at 10/31/12 2:30 AM:
----------------------------------------------------------------

So this issue plagues several other methods in ShoppingCart.java. For each of the methods, the fix is the same: wrap the method content with a loop and change the '0' to 'x'. Example provided in previous comment. Here's a list of all of the methods that need to be changed:

setShippingContactMechId <- patch shown in previous comment
setShipmentMethodTypeId
setShippingInstructions
setMaySplit
setIsGift
setGiftMessage
setCarrierPartyId
setProductStoreShipMethId

This has been tested and works properly by effectively copying all of the shipping details to all of the ship groups.
                
      was (Author: xeomac):
    So this issue plaques several other methods in ShoppingCart.java. For each of the methods, the fix is the same: wrap the method content with a loop and change the '0' to 'x'. Example provided in previous comment. Here's a list of all of the methods that need to be changed:

setShippingContactMechId <- patch shown in previous comment
setShipmentMethodTypeId
setShippingInstructions
setMaySplit
setIsGift
setGiftMessage
setCarrierPartyId
setProductStoreShipMethId

This has been tested and works properly by effectively copying all of the shipping details to all of the ship groups.
                  
> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: demo-trunk.ofbiz.apache.org
>            Reporter: Martin Kreidenweis
>            Assignee: Jacques Le Roux
>
> When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order: 
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned. 
> Possibly offending line of Code: 
> ShoppingCart.java line 2235:
>         this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira