You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/09/01 09:07:29 UTC

[GitHub] ashb edited a comment on issue #3796: [AIRFLOW-2824] - Add config to disable default conn creation

ashb edited a comment on issue #3796: [AIRFLOW-2824] - Add config to disable default conn creation
URL: https://github.com/apache/incubator-airflow/pull/3796#issuecomment-417844535
 
 
   The classes are always available (even when the rbac is not enabled) so we should be able to create migrations for them somehow.
   
   Edit: thinking about it a bit more I'm not sure it makes sense to create Alembic migrations for the Flask RBAC models: if we import the model classes in the migration then the migrations can change over time (we got stung with this already once on our _own_ migrations), or we have to duplicate the model classes in the migration file, which means we have to manually keep them in sync/notice changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services