[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3999: Update schema-41310to41400.sql

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3999: Update schema-41310to41400.sql
URL: https://github.com/apache/cloudstack/pull/3999#discussion_r400475856
 
 

 ##########
 File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql
 ##########
 @@ -19,6 +19,10 @@
 -- Schema upgrade from 4.13.1.0 to 4.14.0.0
 --;
 
+-- Update the description to indicate this only works with KVM + Ceph 
+-- (not implemented properly atm for KVM+NFS/local, and it accidentaly works with XS + NFS. Not applicable for VMware)
+UPDATE `cloud`.`configuration` SET `description`='Indicates whether to always backup primary storage snapshot to secondary storage. Applicable for KVM + Ceph only.' WHERE  `name`='snapshot.backup.to.secondary';
 
 Review comment:
   nice to update in the db, but it needs updating in code: https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java#L59

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services