You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/05 20:47:37 UTC

[GitHub] szha commented on a change in pull request #11159: fix shared_storage free

szha commented on a change in pull request #11159: fix shared_storage free
URL: https://github.com/apache/incubator-mxnet/pull/11159#discussion_r193216734
 
 

 ##########
 File path: src/storage/cpu_shared_storage_manager.h
 ##########
 @@ -215,12 +215,12 @@ void CPUSharedStorageManager::FreeImpl(const Storage::Handle& handle) {
       << "Failed to unmap shared memory. munmap failed with error "
       << strerror(errno);
 
+  if (count == 0) {
 
 Review comment:
   the closing curly brace needs to be moved out of #ifdef __linux__ too

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services