You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/17 10:53:45 UTC
[GitHub] [zookeeper] ayushmantri opened a new pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
ayushmantri opened a new pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645
Properties learner.asyncSending , learner.closeSocketAsync and leader.closeSocketAsync made configurable in zoo.cfg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ayushmantri commented on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
ayushmantri commented on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-806526570
handled property name change in backward compatible way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] functioner commented on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
functioner commented on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-806237060
> @functioner please raise PR to backport ZOOKEEPER-3575 in branch-3.6
@arshadmohammad I raised the PR in #1653.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-805062706
> Do we really need to change the name of the property?
yes, it is required to make it configurable in configuration file zoo.cfg. Currently it is not configurable in zoo.cfg. it must be configured as java system property in some shell script file. For example, before this PR change, if I configure learner.asyncSending=true in zoo.cfg It will not be effective as in ZooKeeper before use this configured property is converted to zookeeper.learner.asyncSending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-804616898
sure @functioner
@ayushmantri please take the description from https://github.com/apache/zookeeper/pull/1582, lets merge this in master branch, we can merge in branch-3.7 later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-804617542
@functioner please raise PR to backport ZOOKEEPER-3575 in branch-3.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-805065751
> What about adding a compatibility layer (reading the old and the new name)
yes, compatibility layer can be added. Only thing is now there will three properties for the same thing
java system properties
- learner.asyncSending
- zookeeper.learner.asyncSending
and normal configuration property, configurable in zoo.cfg
- learner.asyncSending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] functioner commented on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
functioner commented on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-804608014
@arshadmohammad @ayushmantri Thanks for the commit. This configuration is important and helpful for #1582, and I appreciate it. However, the description for `learner.asyncSending` you provide in docs is not as detailed as #1582 I provided. I think providing more details about this configuration is helpful for users and developers. Do you agree? And we can improve the description together if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad edited a comment on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
arshadmohammad edited a comment on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-805062706
> Do we really need to change the name of the property?
yes, it is required to make it configurable in configuration file zoo.cfg. Currently it is not configurable in zoo.cfg. it must be configured as java system property in some shell script file. For example, before this PR change, if I configure learner.asyncSending=true in zoo.cfg It will not be effective as in ZooKeeper before use this configured property is converted to zookeeper.learner.asyncSending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1645: ZOOKEEPER-4257: learner.asyncSending and learner.closeSocketAsync should be configurable in zoo.cfg
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1645:
URL: https://github.com/apache/zookeeper/pull/1645#issuecomment-804331060
Lets wait for the 3.7.0 releases. We have to update the change for branch-3.7. Have to change the property in backward compatible way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org