You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/06 18:35:32 UTC
[GitHub] [druid] jihoonson opened a new pull request #9625: Reuse
transformer in stream indexing
jihoonson opened a new pull request #9625: Reuse transformer in stream indexing
URL: https://github.com/apache/druid/pull/9625
### Description
Initializing a `Transformer` is not cheap; it includes parsing an expression. The `Transformer` should be reused in stream indexing rather than recreating it for every stream chunk. Batch ingestion doesn't have this issue since it decorates an `InputSourceReader` with a `Transformer` which is a reader for the entire input data.
Also fixed JSON serde of `RegexInputFormat`.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [] added documentation for new or modified features or behaviors.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #9625: Reuse transformer in
stream indexing
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #9625: Reuse transformer in stream indexing
URL: https://github.com/apache/druid/pull/9625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org