[GitHub] arina-ielchiieva commented on a change in pull request #1572: DRILL-6879: Show warnings for potential performance issues

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1572: DRILL-6879: Show warnings for potential performance issues
URL: https://github.com/apache/drill/pull/1572#discussion_r240975519
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
 ##########
 @@ -73,6 +73,10 @@ public ProfileWrapper(final QueryProfile profile, DrillConfig drillConfig) {
     final List<MajorFragmentProfile> majors = new ArrayList<>(profile.getFragmentProfileList());
     Collections.sort(majors, Comparators.majorId);
 
+    //Setting warning thresholds for performance-degrading queries (DRILL-6879)
 
 Review comment:
   Do not use static methods, just pass drillConfig in the constructor for each of there classes and set warning threshold value during instance creation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services