You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/19 19:48:17 UTC
[GitHub] [druid] vogievetsky opened a new pull request #11620: Web console: Improve the lookup view UX
vogievetsky opened a new pull request #11620:
URL: https://github.com/apache/druid/pull/11620
This PR aims to make the lookup view more friendly. Here is the before and after screenshots of the lookup view:
### Before:
### After:
The notable changes are:
- `Poll period` and `Summary` are added as additional info columns
- By default the table is ordered on `Lookup name` now
- Validation of the form has been updated to make `Poll period` required for extraction lookups as not setting it is guaranteed to be a time bomb for when a new server is spun up and the lookups go out of sync.
- Error reporting in forms has been improved (see screenshot below)
- The script that extracts SQL functions from the docs has been made more robust (it was not finding the `MV_*` functions before)
- Data loader can auto detect more delimiter types
New inline error validation:
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11620: Web console: Improve the lookup view UX
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11620:
URL: https://github.com/apache/druid/pull/11620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11620: Web console: Improve the lookup view UX
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11620:
URL: https://github.com/apache/druid/pull/11620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a change in pull request #11620: Web console: Improve the lookup view UX
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on a change in pull request #11620:
URL: https://github.com/apache/druid/pull/11620#discussion_r697744861
##########
File path: web-console/src/druid-models/lookup-spec.tsx
##########
@@ -63,6 +63,22 @@ export interface LookupSpec {
readonly injective?: boolean;
}
+function issueWithUri(uri: string): string | undefined {
+ if (!uri) return;
+ const m = /^(\w+):/.exec(uri);
+ if (!m) return `URI is invalid, must start with 'file:', 'hdfs:', or 's3:'`;
+ if (!oneOf(m[1], 'file', 'hdfs', 's3')) {
Review comment:
thanks for the note! Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11620: Web console: Improve the lookup view UX
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11620:
URL: https://github.com/apache/druid/pull/11620#discussion_r695525750
##########
File path: web-console/src/druid-models/lookup-spec.tsx
##########
@@ -63,6 +63,22 @@ export interface LookupSpec {
readonly injective?: boolean;
}
+function issueWithUri(uri: string): string | undefined {
+ if (!uri) return;
+ const m = /^(\w+):/.exec(uri);
+ if (!m) return `URI is invalid, must start with 'file:', 'hdfs:', or 's3:'`;
+ if (!oneOf(m[1], 'file', 'hdfs', 's3')) {
Review comment:
since #11026 google cloud lookups are also supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org