You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/03 08:28:33 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
dongjoon-hyun opened a new pull request #809:
URL: https://github.com/apache/orc/pull/809
### What changes were proposed in this pull request?
This PR aims to migrate `TestVectorOrcFile` to JUnit5.
### Why are the changes needed?
This is the first step to migrate `core` module.
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #809:
URL: https://github.com/apache/orc/pull/809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-891993721
Could you review this please, @williamhyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-892344710
Thank you so much, @williamhyun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-892875295
This is backported to branch-1.7 with #813 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-892875295
This is backported to branch-1.7 with #813 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-892325596
cc @pgaref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #809:
URL: https://github.com/apache/orc/pull/809#discussion_r681550566
##########
File path: java/core/src/test/org/apache/orc/TestVectorOrcFile.java
##########
@@ -88,32 +89,21 @@
import java.util.Map;
import java.util.Random;
import java.util.TimeZone;
+import java.util.UUID;
import java.util.function.IntFunction;
-
-import static junit.framework.TestCase.assertNotNull;
-import static org.junit.Assert.*;
+import java.util.stream.Stream;
Review comment:
For `import` statement ordering, we need to introduce a rule to clean up this. I'll do that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #809: ORC-903: Migrate TestVectorOrcFile to JUnit5
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #809:
URL: https://github.com/apache/orc/pull/809#issuecomment-891993721
Could you review this please, @williamhyun ?
I made this PR first because the whole change is too big for a single review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org